1047654 - "Turn Off the Lights" add-on's fade out animation is very slow with e10s enabled

Status: RESOLVED INCOMPLETE

(Firefox :: Extension Compatibility, defect, P3)

Description

[Stefan vd]

Turn Off the Lights Firefox addon is slow:
https://addons.mozilla.org/en-US/firefox/addon/turn-off-the-lights/


And receive this message in my browser console log:
mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create main.js:431

Comment 1

[Chris Peterson [:cpeterson]]

Stefan: other than the log message about "mutating the [[Prototype]]", did the Ambient Aurea addon behave as expected? The "[[Prototype]]" message is just a warning and should not have any effect on the addon's functionality.

Comment 2

[Stefan vd]

This is the "Turn Off the Lights" bug report. Because the whole extension is slow in that Firefox nightly.
It takes almost 5 seconds, to do the "lights off".

Comment 3

[Chris Peterson [:cpeterson]]

I can reproduce this problem, too. Without e10s, "Turn Off the Lights" dims the page in ~500 milliseconds (as expected). With e10s, "Turn Off the Lights" dims the page in 2–3 seconds.

* billm: do you know why this page dimming extension would take longer with e10s? This bug was filed by Stefan vd, the extension's author.

Comment 4

[Chris Peterson [:cpeterson]]

When I tested Turn Off The Lights with e10s yesterday (comment 3), I could reproduce the ~3 second fade problem. But now that I have updated to the new Turn Off The Lights version 3.0.0.12, I now see a black flash followed by the following error message in the Browser Console:

> NotFoundError: Node was not found

and sometimes followed by an UrgentMessageCheck crash.

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

I tested on the latest nightly and I still see a significant delay when toggling the lights off mode. This didn't happen in Dev Edition.

Comment 6

[Jerod Lycett]

It's taking ~1 second here in Dev 41.0a2, and I doubt it's my machine.

Comment 7

[Jerod Lycett]

I'm now not seeing any speed issue in 42.0a2 Are you still seeing any delay Jorge?

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

I am, but it could be because I'm using an old computer and video card. If this isn't happening to anyone else, I think it's okay to close this bug.

Comment 9

[Rolandas]

43.0a1 - I'm still seeing delay. Windows 10. This didn't happen when I used Firefox 39.0.

Comment 10

[Jerod Lycett]

I'm seeing delays in 43.0a1, but again, only about a second. Definitely confusing to me.

Comment 11

[Tracy Walker [:tracy]]

The fade happens in less than a second for me.  Seems to be a bit of a delay in fade off vs fade on.  But this certainly isn't "very slow" as reported.

Comment 12

[Stefan vd]

I don't know who report this as closed. But here on my Mac on Firefox 46.0.a1 it takes 6 seconds (with the spinning Mac loading icon) and then it dims the page.

Comment 13

[:shell escalante]

will need to test, just saw the webextensions version land yesterday.  looks like a cool add-on i would use anyway, and i'm on a mac.  need info'd myself to get to later this week and close if works.

Comment 14

[Michelle Funches - QA]

Still seeing  a delay when e10s is enabled on initial access, the more I toggle the faster it appears. Also when e10s is disabled I see the same.
Turn Off the Lights 3.3.0.0
Version 	51.0a2
Build ID 	20161005004013
User Agent 	Mozilla/5.0 (X11; Linux i686; rv:51.0) Gecko/20100101 Firefox/51.0

Comment 15

[Firefox Bug Husbandry Bot]

With Firefox 57 only WebExtensions are permitted and are, by default, e10s compatible.