1047674 - Move AppConstants into mozglue (or an earlier build stage)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

We'd like to use it from GeckoLoader, utils, etc.

Right now those places either redefine constants, or don't take advantage of features (e.g., AppConstants.Versions).

Comment 1

[Richard Newman [:rnewman]]

Attachment: Move AppConstants into mozglue. v1

This is the most minimal patch: we don't move the file, just build the same file at a different point.

This has the advantages of not having to change a-s import scripts or file imports elsewhere in the tree.

The only disadvantage is that we have a file being built into the intermediate mozglue jar that isn't in the mozglue directory.

That doesn't bother me; if it bothers you, say so!

Tested that this makes AppConstants available to utils, so as a follow-up we can use AppConstants in more places.

Comment 2

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/9134e79e230d

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9134e79e230d