Closed Bug 1047980 Opened 5 years ago Closed Last year

Notification bar buttons: weird border

Categories

(Toolkit :: Themes, defect)

33 Branch
All
macOS
defect
Not set

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox33 --- affected
firefox34 --- affected

People

(Reporter: soeren.hentzschel, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Attached image screenshot
The border of the buttons in the notification bar on OS X (for example the notification bar of bug 693808) is really weird: the bottom is thicker than the top, the left looks cut off.
Version: Trunk → 33 Branch
TBH, because all the notification bars since Firefox 3 or perhaps before (honestly, I don't remember when we switched to this style) have looked like this, I'm not sure there's any dependency here or something that we desperately need to fix right now. Additionally, I thought that we were redoing the notification bar design in bug 1025182. Stephen, can you confirm/deny the above?
No longer blocks: 693808
Component: Theme → Themes
Flags: needinfo?(shorlander)
Product: Firefox → Toolkit
My memory might be faulty but I think at one point the border was actually a translucent black that meshed better and didn't conflict with the lighter drop-shadow. If not, that's how it was supposed to look ;) Or maybe it is just more noticeable on Retina.

Patch changes background-clip to padding-box so that the border blends with the notification bar background.
Flags: needinfo?(shorlander)
Attachment #8576101 - Flags: review?(gijskruitbosch+bugs)
Attached image New button style
Is this what it's meant to look like, Stephen? Doesn't look right to me with the additional black border... but maybe that's just stockholm syndrome or whatever?
Flags: needinfo?(shorlander)
Comment on attachment 8576101 [details] [diff] [review]
fix-notification-bar-border.patch - 01

Review of attachment 8576101 [details] [diff] [review]:
-----------------------------------------------------------------

Clearing for now, please re-request if the style in the attachment is indeed what you're going for...
Attachment #8576101 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8576101 [details] [diff] [review]
fix-notification-bar-border.patch - 01

Yes, that is what I was after ;)
Flags: needinfo?(shorlander)
Attachment #8576101 - Flags: review?(gijskruitbosch+bugs)
Attachment #8576101 - Flags: review?(gijskruitbosch+bugs) → review+
No longer an issue with the Photon design.
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.