1047980 - Notification bar buttons: weird border

Status: RESOLVED WORKSFORME

(Toolkit :: Themes, defect)

Description

[Sören Hentzschel]

Attachment: screenshot

The border of the buttons in the notification bar on OS X (for example the notification bar of bug 693808) is really weird: the bottom is thicker than the top, the left looks cut off.

Comment 1

[:Gijs (he/him)]

TBH, because all the notification bars since Firefox 3 or perhaps before (honestly, I don't remember when we switched to this style) have looked like this, I'm not sure there's any dependency here or something that we desperately need to fix right now. Additionally, I thought that we were redoing the notification bar design in bug 1025182. Stephen, can you confirm/deny the above?

Comment 2

[Stephen Horlander [:shorlander]]

Attachment: fix-notification-bar-border.patch - 01

My memory might be faulty but I think at one point the border was actually a translucent black that meshed better and didn't conflict with the lighter drop-shadow. If not, that's how it was supposed to look ;) Or maybe it is just more noticeable on Retina.

Patch changes background-clip to padding-box so that the border blends with the notification bar background.

Comment 3

[:Gijs (he/him)]

Attachment: New button style

Is this what it's meant to look like, Stephen? Doesn't look right to me with the additional black border... but maybe that's just stockholm syndrome or whatever?

Comment 4

[:Gijs (he/him)]

Comment on attachment 8576101 [details] [diff] [review]
fix-notification-bar-border.patch - 01

Review of attachment 8576101 [details] [diff] [review]:
-----------------------------------------------------------------

Clearing for now, please re-request if the style in the attachment is indeed what you're going for...

Comment 5

[Stephen Horlander [:shorlander]]

Comment on attachment 8576101 [details] [diff] [review]
fix-notification-bar-border.patch - 01

Yes, that is what I was after ;)

Comment 6

[Sören Hentzschel]

No longer an issue with the Photon design.