1047988 - Transition between the minimized and maximized statusbar states

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I don't particularly like the animation, but it seems to be what UX wanted in https://bug1042105.bugzilla.mozilla.org/attachment.cgi?id=8465121

In the worst case it can be tweak pretty easily.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: transition.statusbar.states.patch

This patch is on top of bug 1047829 fwiw.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8466771 [details] [diff] [review]
transition.statusbar.states.patch

Review of attachment 8466771 [details] [diff] [review]:
-----------------------------------------------------------------

Like you said, I'm also not really a fan of this transition. I find the transition of the statusbar icons too quick, and it's extremely jarring to browse websites when it flashes.

Do we need to land this immediately, or can we wait for later in the release cycle?

Also would like to get Francis/Eric to review the UX - because I think it's really jarring. Maybe after playing with the patch they will agree.

Comment 3

[Kevin Grandon :kgrandon]

I think we can do the prioritization without this specifically?

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug1047988.patch

Let's get rid of the transition.

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8467152 [details] [diff] [review]
bug1047988.patch

Review of attachment 8467152 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good to me, thanks!

Comment 6

[Guillaume Marty [:gmarty]]

For memory, the ID for the max and min status bars from bug 1042105 are #statusbar-maximised and #statusbar-minimised, so the selectors from this patch (app_titlebar.css from line 23) should look like this:

.appWindow .titlebar .titlebar-maximized {
  background-image: -moz-element(#statusbar-maximised);
}

.appWindow .titlebar .titlebar-minimized {
  background-image: -moz-element(#statusbar-minimised);
}

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/80a2928c648187c13200d2057ba9e585f6b6d4b3