Closed Bug 1047988 Opened 5 years ago Closed 5 years ago

Transition between the minimized and maximized statusbar states

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vingtetun, Assigned: vingtetun)

References

Details

Attachments

(1 file, 1 obsolete file)

I don't particularly like the animation, but it seems to be what UX wanted in https://bug1042105.bugzilla.mozilla.org/attachment.cgi?id=8465121

In the worst case it can be tweak pretty easily.
This patch is on top of bug 1047829 fwiw.
Attachment #8466771 - Flags: review?(kgrandon)
Comment on attachment 8466771 [details] [diff] [review]
transition.statusbar.states.patch

Review of attachment 8466771 [details] [diff] [review]:
-----------------------------------------------------------------

Like you said, I'm also not really a fan of this transition. I find the transition of the statusbar icons too quick, and it's extremely jarring to browse websites when it flashes.

Do we need to land this immediately, or can we wait for later in the release cycle?

Also would like to get Francis/Eric to review the UX - because I think it's really jarring. Maybe after playing with the patch they will agree.
Attachment #8466771 - Flags: ui-review?(fdjabri)
Attachment #8466771 - Flags: ui-review?(epang)
Attachment #8466771 - Flags: review?(kgrandon)
I think we can do the prioritization without this specifically?
Blocks: rocketbar-search-mvp
No longer blocks: 1042105
Attached patch bug1047988.patchSplinter Review
Let's get rid of the transition.
Attachment #8466771 - Attachment is obsolete: true
Attachment #8466771 - Flags: ui-review?(fdjabri)
Attachment #8466771 - Flags: ui-review?(epang)
Attachment #8467152 - Flags: review?(kgrandon)
Comment on attachment 8467152 [details] [diff] [review]
bug1047988.patch

Review of attachment 8467152 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good to me, thanks!
Attachment #8467152 - Flags: review?(kgrandon) → review+
For memory, the ID for the max and min status bars from bug 1042105 are #statusbar-maximised and #statusbar-minimised, so the selectors from this patch (app_titlebar.css from line 23) should look like this:

.appWindow .titlebar .titlebar-maximized {
  background-image: -moz-element(#statusbar-maximised);
}

.appWindow .titlebar .titlebar-minimized {
  background-image: -moz-element(#statusbar-minimised);
}
https://github.com/mozilla-b2g/gaia/commit/80a2928c648187c13200d2057ba9e585f6b6d4b3
Assignee: nobody → 21
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.