Closed
Bug 1048000
Opened 10 years ago
Closed 10 years ago
Download cancel dialog shows undefinedYes and undefinedNo aa button values
Categories
(Firefox for Android Graveyard :: Download Manager, defect)
Tracking
(fennec33+)
RESOLVED
FIXED
Firefox 34
| Tracking | Status | |
|---|---|---|
| fennec | 33+ | --- |
People
(Reporter: kats, Assigned: wesj)
References
Details
Attachments
(1 file)
|
1.06 KB,
patch
|
bnicholson
:
review+
|
Details | Diff | Splinter Review |
Nexus 4 running recent nightly. Go to https://bugzilla.mozilla.org/show_bug.cgi?id=1047127 and click on the link to the profile aaron posted. This starts a download. Open the notification tray and tap on the download entry. This pops up a dialog to cancel the download. The buttons say "undefinedNo" and "undefinedYes" instead of "no" and "yes".
|
Reporter | |
Updated•10 years ago
|
tracking-fennec: --- → ?
|
||
Updated•10 years ago
|
Assignee: nobody → wjohnston
tracking-fennec: ? → 33+
|
Assignee | |
Comment 1•10 years ago
|
||
This is actually a regression from a fix to the JS engine in bug 369778. RegExps now return undefined instead of "" for unmatched conditions. This is the same fix used in CommonDialog.js for Desktop.
Attachment #8471051 -
Flags: review?(bnicholson)
|
||
Updated•10 years ago
|
Attachment #8471051 -
Flags: review?(bnicholson) → review+
|
||
Comment 2•10 years ago
|
||
I also saw a similar issue in the slow script dialog checkbox last night. Will this fix that issue as well?
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/f47e1ba9ceca yes
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f47e1ba9ceca
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•