Last Comment Bug 1048000 - Download cancel dialog shows undefinedYes and undefinedNo aa button values
: Download cancel dialog shows undefinedYes and undefinedNo aa button values
Status: RESOLVED FIXED
:
Product: Firefox for Android
Classification: Client Software
Component: Download Manager (show other bugs)
: 34 Branch
: ARM Android
-- normal (vote)
: Firefox 34
Assigned To: Wesley Johnston (:wesj)
:
: Sebastian Kaspari (:sebastian)
Mentors:
Depends on:
Blocks: 369778
  Show dependency treegraph
 
Reported: 2014-08-03 05:56 PDT by (away until Feb21) Kartikaya Gupta (email:kats@mozilla.com)
Modified: 2014-08-19 17:25 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
33+


Attachments
Patch (1.06 KB, patch)
2014-08-11 13:04 PDT, Wesley Johnston (:wesj)
bnicholson: review+
Details | Diff | Splinter Review

Description User image (away until Feb21) Kartikaya Gupta (email:kats@mozilla.com) 2014-08-03 05:56:59 PDT
Nexus 4 running recent nightly. Go to https://bugzilla.mozilla.org/show_bug.cgi?id=1047127 and click on the link to the profile aaron posted. This starts a download. Open the notification tray and tap on the download entry. This pops up a dialog to cancel the download. The buttons say "undefinedNo" and "undefinedYes" instead of "no" and "yes".
Comment 1 User image Wesley Johnston (:wesj) 2014-08-11 13:04:38 PDT
Created attachment 8471051 [details] [diff] [review]
Patch

This is actually a regression from a fix to the JS engine in bug 369778. RegExps now return undefined instead of "" for unmatched conditions. This is the same fix used in CommonDialog.js for Desktop.
Comment 2 User image :Margaret Leibovic 2014-08-12 08:53:25 PDT
I also saw a similar issue in the slow script dialog checkbox last night. Will this fix that issue as well?
Comment 3 User image Wesley Johnston (:wesj) 2014-08-13 14:56:58 PDT
https://hg.mozilla.org/integration/fx-team/rev/f47e1ba9ceca
yes
Comment 4 User image Ed Morley [:emorley] 2014-08-14 00:54:10 PDT
https://hg.mozilla.org/mozilla-central/rev/f47e1ba9ceca

Note You need to log in before you can comment on or make changes to this bug.