The default bug view has changed. See this FAQ.

Download cancel dialog shows undefinedYes and undefinedNo aa button values

RESOLVED FIXED in Firefox 34

Status

()

Firefox for Android
Download Manager
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kats, Assigned: wesj)

Tracking

34 Branch
Firefox 34
ARM
Android
Points:
---

Firefox Tracking Flags

(fennec33+)

Details

Attachments

(1 attachment)

Nexus 4 running recent nightly. Go to https://bugzilla.mozilla.org/show_bug.cgi?id=1047127 and click on the link to the profile aaron posted. This starts a download. Open the notification tray and tap on the download entry. This pops up a dialog to cancel the download. The buttons say "undefinedNo" and "undefinedYes" instead of "no" and "yes".
tracking-fennec: --- → ?
Assignee: nobody → wjohnston
tracking-fennec: ? → 33+
(Assignee)

Comment 1

3 years ago
Created attachment 8471051 [details] [diff] [review]
Patch

This is actually a regression from a fix to the JS engine in bug 369778. RegExps now return undefined instead of "" for unmatched conditions. This is the same fix used in CommonDialog.js for Desktop.
Attachment #8471051 - Flags: review?(bnicholson)
(Assignee)

Updated

3 years ago
Blocks: 369778
Attachment #8471051 - Flags: review?(bnicholson) → review+

Comment 2

3 years ago
I also saw a similar issue in the slow script dialog checkbox last night. Will this fix that issue as well?
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/f47e1ba9ceca
yes
https://hg.mozilla.org/mozilla-central/rev/f47e1ba9ceca
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
You need to log in before you can comment on or make changes to this bug.