Closed Bug 1048000 Opened 10 years ago Closed 10 years ago

Download cancel dialog shows undefinedYes and undefinedNo aa button values

Categories

(Firefox for Android Graveyard :: Download Manager, defect)

34 Branch
ARM
Android
defect
Not set
normal

Tracking

(fennec33+)

RESOLVED FIXED
Firefox 34
Tracking Status
fennec 33+ ---

People

(Reporter: kats, Assigned: wesj)

References

Details

Attachments

(1 file)

Nexus 4 running recent nightly. Go to https://bugzilla.mozilla.org/show_bug.cgi?id=1047127 and click on the link to the profile aaron posted. This starts a download. Open the notification tray and tap on the download entry. This pops up a dialog to cancel the download. The buttons say "undefinedNo" and "undefinedYes" instead of "no" and "yes".
tracking-fennec: --- → ?
Assignee: nobody → wjohnston
tracking-fennec: ? → 33+
Attached patch PatchSplinter Review
This is actually a regression from a fix to the JS engine in bug 369778. RegExps now return undefined instead of "" for unmatched conditions. This is the same fix used in CommonDialog.js for Desktop.
Attachment #8471051 - Flags: review?(bnicholson)
Blocks: 369778
Attachment #8471051 - Flags: review?(bnicholson) → review+
I also saw a similar issue in the slow script dialog checkbox last night. Will this fix that issue as well?
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: