1048005 - [EverythingMe] CDN urls for web results icons

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Amir Nissim (:amirn)]

EverythingMe API added supported for CDN versions for web results icons.
We can use it for better loading experience.

Comment 1

[Amir Nissim (:amirn)]

[Blocking Requested - why for this release]:
This is the first release using the new E.me API, and this patch will improve load times in the Collections and Search apps.

Comment 2

[Preeti Raghunath(:Preeti)]

How much improvement are we talking about?

Also is this a new feature?

Comment 3

[Amir Nissim (:amirn)]

Attachment: Pull Request

Comment 4

[Amir Nissim (:amirn)]

(In reply to Preeti Raghunath(:Preeti) from comment #2)
> How much improvement are we talking about?
> 
> Also is this a new feature?

This is a followup on a new feature implemented for v2.0, and is mainly a backend feature.
The gaia patch to support it is a one-liner with no risk (attachment 8468265 [details] [review]).

Dvir, can you provide some numbers on the performance gain?

Comment 5

[Jason Smith [:jsmith]]

Mike - Can you weigh in here to see if this is a blocker from a performance perspective?

Comment 6

[bhavana bajaj [:bajaj]]

I am blocking on this and making an exception given the super low risk and keeping in mind comment #4. If there are any fallouts we should backout.

Comment 7

[Amir Nissim (:amirn)]

Comment on attachment 8468265 [details] [review]
Pull Request

master: https://github.com/mozilla-b2g/gaia/commit/91b71ecfef3862efc91b247a8a857f74df2cc9d8

Comment 8

[Amir Nissim (:amirn)]

Comment on attachment 8468265 [details] [review]
Pull Request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): backend feature
[User impact] if declined: icons load time will increase
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: updated E.me URL regex to support CDN urls

Comment 9

[Gregor Wagner [:gwagner]]

Comment on attachment 8468265 [details] [review]
Pull Request

This is already blocking 2.0. No need to ask for approval.

Comment 10

[Gregor Wagner [:gwagner]]

Fixed on master based on comment 7.

Comment 11

[Amir Nissim (:amirn)]

we need to land the dependency as well, requested approval for bug 1028664.

Comment 12

[Amir Nissim (:amirn)]

v2.0 https://github.com/mozilla-b2g/gaia/commit/88e774c606520c9ce349b467866e200e8db31af4

Comment 13

[Paladin]

Attachment: Verify_image.png

Hi Amir,
I'm not sure the issue has been fixed.
Please refer to the picture, Could you please help to confirm this issue has fixed?

STR:
1)On the homescreen, tap on the Rocket bar.
2)Input some characters.

See Attachment:Verify_image.png
--------------------------------------------------------------------------------
Information:
Flame 2.0 build:
Gaia-Rev        856863962362030174bae4e03d59c3ebbc182473
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/e40fe21e37f1
Build-ID        20141207000206
Version         32.0

Flame2.1 build:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0

Comment 14

[Amir Nissim (:amirn)]

Yes, this issue is fixed.
Not sure what makes you think otherwise, the attached screenshot looks ok to me - all app icons are loaded.

Comment 15

[Ran Ben Aharon [:ranbena] EverythingMe]

Paladin, if you're referring to the black background color - it's not related to this ticket.