1048012 - Provide a better error handling instead of |NS_RUNTIMEABORT("OOM")| introduced in Bug 950076

Status: RESOLVED DUPLICATE of bug 1167189

(Core :: DOM: Core & HTML, defect)

Description

[Alessio Placitelli [:Dexter]]

Bug 950076 introduced a few |NS_RUNTIMEABORT("OOM")| to handle out of memory situations (See https://bugzilla.mozilla.org/attachment.cgi?id=8394385).

As highlighted in Bug 1037214, those aborts should either be handled or replaced with NS_ABORT_OOM(size).

Comment 1

[Alessio Placitelli [:Dexter]]

This is a list of the |NS_RUNTIMEABORT("OOM")| that need to be taken care of:

- |nsDocument::GetTitleFromElement|  http://dxr.mozilla.org/mozilla-central/source/content/base/src/nsDocument.cpp#6682

- |nsTreeSanitizer::SanitizeChildren| http://dxr.mozilla.org/mozilla-central/source/content/base/src/nsTreeSanitizer.cpp#1402

- |HTMLMenuItemElement::GetText| http://dxr.mozilla.org/mozilla-central/source/content/html/content/src/HTMLMenuItemElement.cpp#375

- |HTMLOutputElement::GetValue| http://dxr.mozilla.org/mozilla-central/source/content/html/content/src/HTMLOutputElement.cpp#150

- |HTMLOutputElement::DescendantsChanged()| http://dxr.mozilla.org/mozilla-central/source/content/html/content/src/HTMLOutputElement.cpp#183

- |SVGScriptElement::GetScriptText| http://dxr.mozilla.org/mozilla-central/source/content/svg/content/src/SVGScriptElement.cpp#124

- |nsXBLPrototypeBinding::AttributeChanged| http://dxr.mozilla.org/mozilla-central/source/dom/xbl/nsXBLPrototypeBinding.cpp#364

- |static PLDHashOperator
SetAttrs| http://dxr.mozilla.org/mozilla-central/source/dom/xbl/nsXBLPrototypeBinding.cpp#518

- |nsMathMLTokenFrame::MarkTextFramesAsTokenMathML| http://dxr.mozilla.org/mozilla-central/source/layout/mathml/nsMathMLTokenFrame.cpp#81

- |nsMathMLmoFrame::ProcessTextData| http://dxr.mozilla.org/mozilla-central/source/layout/mathml/nsMathMLmoFrame.cpp#119

Comment 2

[Alessio Placitelli [:Dexter]]

Errata: as mentioned by :jst in bug 950076 comment 22, |NS_RUNTIMEABORT("OOM")| should be kept in nsXBLPrototypeBinding.cpp.

Comment 3

[Benjamin Smedberg]

That one should probably be NS_ABORT_OOM, now that we have it. It produces better crash-stats results.

Comment 4

[Patrick]

Hi Alessio, I am also interested in taking this on. Please advise

Comment 5

[Patrick]

Is this also a mentored bug?

Comment 6

[Alessio Placitelli [:Dexter]]

No Patrick, this isn't a mentored bug.

Comment 7

[Chris Peterson [:cpeterson]]

Bug 1167189 replaced NS_RUNTIMEABORT("OOM") with NS_ABORT_OOM(0) in Firefox 39.