1048093 - [Bluetooth] Transfer files from Gallery would freeze the system

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

This bug is with two STRs:

STR A:

1. Have multiple photos in Gallery
2. Select them (6 in the sample video)
3. Share them with Bluetooth

STR B:

1. Record one video about 70MB
2. Select it to transfer with Bluetooth

Expected:

Transferring done without any issue

Actual:

System freeze. It's critical because I can only recover the device via forcibly reset it.

I've tested with two Flames, while the STR B was discovered when I recorded a video about STR A, and it occurred while I try to send the file to my Mac.

Flame A (6 photos):

Gecko: 34.0a1, 20140803160202, Nightly channel
Gaia: 2014-08-01 18:18:25, 5fd14b8b
Base Image: v122

Flame B (70MB video):

Gecko: 34.0a1, 20140803160202, Nightly channel
Gaia: 2014-08-04 01:43:08, eae74908
Base Image: v123

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

The video:

https://www.youtube.com/watch?v=z7lIaTLXwVI

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

NI Eric since I've show the bug to him offline.

Comment 3

[Eric Chou [:ericchou] [:echou]]

Taking it.

Comment 4

[Eric Chou [:ericchou] [:echou]]

[Blocking Requested - why for this release]:

I can confirm this is reproducible by flashing the latest m-c build. Mark regression and nominate as 2.1+.

Comment 5

[Eric Chou [:ericchou] [:echou]]

Just tried aurora(2.0) and this doesn't seem to be reproducible.

Comment 6

[Eric Chou [:ericchou] [:echou]]

This could also happen even if only one photo is sent.

Comment 7

[Eric Chou [:ericchou] [:echou]]

ok, looks like this is caused by bug 1046109 patches. After reverting all of them on top of the latest m-c, file transferring via Bluetooth could work as expected.

Thomas, would you mind taking a look?

Comment 8

[Eric Chou [:ericchou] [:echou]]

(In reply to Eric Chou [:ericchou] [:echou] from comment #7)
> ok, looks like this is caused by bug 1046109 patches. After reverting all of
> them on top of the latest m-c, file transferring via Bluetooth could work as
> expected.
> 
> Thomas, would you mind taking a look?

Forgot to mention that this happens on Flame which is using BlueZ as bt backend.

Comment 9

[Thomas Zimmermann [:tzimmermann] [:tdz]]

OK, let me see.

Comment 10

[Eric Chou [:ericchou] [:echou]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #9)
> OK, let me see.

Thanks :)

Comment 11

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1048093: Delete sent socket-data objects instead of raw data

Thanks Eric for pointing me in the right direction.

Comment 12

[Thomas Zimmermann [:tzimmermann] [:tdz]]

The bug was introduced by patch [07] of bug 1046109.

Comment 13

[Eric Chou [:ericchou] [:echou]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #11)
> Created attachment 8470025 [details] [diff] [review]
> [01] Bug 1048093: Delete sent socket-data objects instead of raw data
> 
> Thanks Eric for pointing me in the right direction.

So efficient! Thank you, Thomas. :)

Comment 14

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Just curious, since we're now supposed to be getting better C++ testing with gtest, might it be worth starting to look at writing a test suite for unixsocket?

Comment 15

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #14)
> Just curious, since we're now supposed to be getting better C++ testing with
> gtest, might it be worth starting to look at writing a test suite for
> unixsocket?

What do we need to do and how do such tests look like? I briefly read [1] and [2] but I'm not sure if I'd known to implement a test. Also, there seem to be thread-safety issues (?) with gtest. Could this be a problem for the multi-threaded UnixSocket.cpp?

[1] https://developer.mozilla.org/en-US/docs/GTest
[2] https://code.google.com/p/googletest/wiki/Primer

Comment 16

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://hg.mozilla.org/integration/b2g-inbound/rev/bb3ae546ff71

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=bb3ae546ff71

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bb3ae546ff71

Comment 18

[Alison Shiue]

Verified on
Gaia      8f955d80d175e52283275d3197e4eae2574b389f
Gecko     https://hg.mozilla.org/mozilla-central/rev/391f42c733fc
BuildID   20140811160202
Version   34.0a1

Comment 19

[howie [:howie]]

regression, mark as 2.1+, thanks for the fix.

Comment 20

[Sue]

Attachment: video of picture transfer

This issue can't repro on Flame 2.1
See attachment: verify_video_picture.mp4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        1b231b87aad384842dfc79614b2a9ca68a4b4ff3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/95fbd7635152
Build-ID        20141118001204
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141118.035447
FW-Date         Tue Nov 18 03:54:58 EST 2014
Bootloader      L1TC00011880

Comment 21

[Sue]

Attachment: video of video transfer