Closed Bug 1048134 Opened 10 years ago Closed 9 years ago

Remove talos.zip support

Categories

(Testing :: Talos, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Unassigned)

References

Details

(Whiteboard: talos-android)

It is my understanding that:

1) All mozharness talos jobs use the talos repo directly (vs a manually created talos.zip), via:

http://mxr.mozilla.org/mozilla-central/source/testing/talos/talos.json#6
6     "global": {
7         "talos_repo": "https://hg.mozilla.org/build/talos",
8         "talos_revision": "c36273c3498d"
9     },

2) The last remaining non-mozharness talos jobs were the tegra talos jobs, which have now been switched off on trunk by bug 1016453 and deps.

As such, I believe we can now remove for things like:

http://mxr.mozilla.org/mozilla-central/source/testing/talos/talos.json#2
2     "talos.zip": {
3         "url": "http://talos-bundles.pvt.build.mozilla.org/zips/talos.b826a38ef31f.zip",
4         "path": ""
5     },

http://mxr.mozilla.org/mozilla-central/source/testing/talos/talos_from_code.py#48
45     # 3) download the necessary files
46     print "INFO: talos.json URL: %s" % options.talos_json_url
47     try:
48         key = 'talos.zip'
...

http://mxr.mozilla.org/build-central/source/mozharness/scripts/android_panda_talos.py#318
318         talos_zip_path = (os.path.join(dirs['abs_talosdata_dir'], "talos.zip"))


http://mxr.mozilla.org/build-central/source/talos/create_talos_zip.py
(this whole file is now redundant)

In addition, I guess if the buildbotcustom talos code is now not used (since it's handled inside mozharness now), we could always clean that up too - but perhaps in another bug.
I chatted with :kmoir about this briefly a few weeks ago.  The panda mozharness script still relies on talos.zip:
http://hg.mozilla.org/build/mozharness/file/0c2710a85246/scripts/android_panda_talos.py#l318

I am sure this is a reasonable thing to resolve, it just takes prioritization and some time to fix the mozharness script.

:kmoir, can you add any more information here?  Is fixing the mozharness script an item in your queue already?
Flags: needinfo?(kmoir)
:jmaher: It's in my queue but right now I'm working on bug 1019724 and bug 1019919 and these are taking a long time to fix.  (not that familiar with balrog and each test run takes a long time)
Flags: needinfo?(kmoir)
See Also: → 1187684
Whiteboard: talos-android
I am going to resolve this as fixed since we have successfully been running the remaining android talos tests in autophone with a plan in the next few weeks to turn talos off.  All talos.zip related code has been removed from talos a few months ago- I don't think it makes sense to have this bug track anything.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.