1187684 - Remove android-related code from Talos

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Julien Pagès (:parkouss)]

Since we are going to drop support for android in Talos, there is a bunch of things we can clean up.

This bug is intended to track that - I am starting for now with a 'no-android' branch on my personal clone:

https://bitbucket.org/parkouss/talos/commits/branch/no-android

Comment 1

[Julien Pagès (:parkouss)]

Well I pushed my first work on try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=35d1e57bdaf4

(I re-triggered every build since first attempt failed, but now looking good so far!)

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

wow, this is great stuff.

I like that it is running and looking green.

A couple thoughts:
* I believe we need the webserver logic for running with --develop.  That has a custom port on localhost which we need to define in prefs and in the manifest.
* I saw some removals of _hostproc, but other uses of it, maybe more cleanup is needed, or I just got confused.
* in addition there are a lot of other files to remove, removals are easier than edits.

One way to tackle this is to just get this ready, added in-tree under testing/talos and then over the next week work on fixing up the mozharness scripts.  If we can land this on aurora as well, then we can take advantage of the uplift to beta.

Can you verify you can run locally with --develop?

Comment 3

[Julien Pagès (:parkouss)]

(In reply to Joel Maher (:jmaher) from comment #2)
> wow, this is great stuff.

Thanks!

> 
> I like that it is running and looking green.
> 
> A couple thoughts:
> * I believe we need the webserver logic for running with --develop.  That
> has a custom port on localhost which we need to define in prefs and in the
> manifest.

Well, I tested "talos -a tresize --cycles 2 -e `which firefox` --develop" and it works fine for me. Maybe I missed something ?

> * I saw some removals of _hostproc, but other uses of it, maybe more cleanup
> is needed, or I just got confused.

Oh, I probably missed that (and other stuff!) - I'll look at this one and I suspect we will remove more when we will clean up things (like configuration.py).

> * in addition there are a lot of other files to remove, removals are easier
> than edits.

I was not sure, I first tried to remove the python code (I must admit I have almost no knowledge of the javascript part of Talos). Maybe you could guide me for what to remove - or remove them directly.

> 
> One way to tackle this is to just get this ready, added in-tree under
> testing/talos and then over the next week work on fixing up the mozharness
> scripts.  If we can land this on aurora as well, then we can take advantage
> of the uplift to beta.

Well, why not, sounds pretty good. I am just a bit worried that it may take time to get talos in tree, (maybe legal issues for some part of the code if I got it well). That's why I proposed another branch on Talos, and we could keep the out-tree thing for now, but making m-c point to the non-android branch for desktop. Plus we keep the ability to try talos multiple times with one push try and that could be useful while we are refactoring things.

As you want!

> 
> Can you verify you can run locally with --develop?

It runs fine locally with --develop, with the command above. Please tell me if I need to test another command or something.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: files we can remove which are not used or for android only

Comment 5

[Julien Pagès (:parkouss)]

Comment on attachment 8639213 [details] [diff] [review]
files we can remove which are not used or for android only

Great!

I pushed that on my clone (https://bitbucket.org/parkouss/talos/commits/branch/no-android), will re-trigger a few builds to see if that pass.

Comment 7

[Julien Pagès (:parkouss)]

So as discussed on irc, we will push that code in the default branch of talos (until talos is in tree). So, working as usual. This won't impact android as it uses zip bundles:

https://dxr.mozilla.org/mozilla-central/source/testing/talos/talos.json?from=talos.json#3

******************************
In case android version needs to be updated
******************************

In that case, we will create an 'android' branch. First thing is to update to the last working version of talos for android:

> # Note a6052c33d420 is the revision I got from the m-c version of the "talos.zip" "url" in testing/talos/talos.json
> hg up a6052c33d420

> # now, create the branch
> hg branch android

> # write the code to fix the issue... then commit
> hg commit

> # check that everything is good
> hgview # or "hg log -G | less" or whatever

# when you are sure, you can commit that
> hg push -r .

> # create talos bundle as usual, then update the "url" in testing/talos/talos.json


From there, every time android would need to be fixed, do the same thing over - except you don't have to do again the branch creation.

******************************


jmaher, is it good a good enough explanation ? Note I don't know how to create the talos.zip, but I think you know. :)

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

this is good enough, thanks for doing this.  I think we should go ahead and start removing things!

Comment 9

[Julien Pagès (:parkouss)]

Attachment: remove_android.patch

So, let's follow the rules. :)

Well I just squashed every commit from my no-android branch (including the commit you did to remove files) into one for simplicity. (I hope you don't mind, all the work is now under my name so tell me if you prefer two separate commits - I just thought you would prefer this way).

We should push that to try one last time, I think it is ok here to be extra paranoid! It is working fine locally.

Joel, do you mind pushing this to try ?

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8640321 [details] [diff] [review]
remove_android.patch

Review of attachment 8640321 [details] [diff] [review]:
-----------------------------------------------------------------

having reviewed this before, I am happy with r+ after a sanity check.

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/build/talos/rev/09f1083a869b