1048141 - [v2.1] After importing contact from gmail the import screen does not disappear

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Robert Chira [:RobertC]]

Attachment: gmail_import.png

The import contacts screen does not disappear after successfully importing users from gmail.
This issue is reproduced with both manual and automated tests.

Build environment v2.1 flame:
Device firmware (date) 	27 Jun 2014 00:57:58
Device firmware (incremental) 	110
Device firmware (release) 	4.3
Device identifier 	flame
Gaia date 	01 Aug 2014 11:18:25
Gaia revision 	5fd14b8bc428
Gecko build 	20140803160202
Gecko revision 	e6614d8d85f9
Gecko version 	34.0a1

STR:
1. got to contacts -> settings -> import contacts
2. tap import from gmail (login to google account)
3. select contacts and tap import

Expected result:
A new screen should appear that shows the number of contacts that are being imported after which it disappears

Actual result:
After importing the screen does not disappear (see attached screenshot)

Comment 1

[Robert Chira [:RobertC]]

Attachment: logcat.txt

I have attached the logcat from when I reproduced the issue manually.

Comment 2

[Jason Smith [:jsmith]]

QA Wanted for branch checks.

Comment 3

[Chris Kreinbring [:CKreinbring]]

The bug repros on Buri 2.1
Actual result: After importing contacts from a Gmail or Outlook email account, the progress indication page will not disappear until the user taps the Cancel button.

Build ID: 20140804041427
Gaia: af9a0a24fb9f4c5ced3602bc14053bd49b136344
Gecko: 71497ed2e0db
Platform Version: 34.0a1
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

--------------------------------------------------------------------------------------------------------

The bug does not repro on Flame 2.0
Actual result: After importing contacts from a Gmail or Outlook email account, the progress indication page will disappear on its own.

Build ID: 20140804060132
Gaia: 4ab7384db7aee130be165a699472cc19405a4456
Gecko: 5e94ab16ec71
Platform Version: 32.0
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 4

[Joshua Mitchell (Inactive)]

triage - would not block on this issue, there are several ways around this screen and they all successfully import the contacts.

Comment 5

[Jason Smith [:jsmith]]

(In reply to Joshua Mitchell [:Joshua_M] from comment #4)
> triage - would not block on this issue, there are several ways around this
> screen and they all successfully import the contacts.

It is possible to workaround, but the UX here seems a bit questionable. We're leaving the user in a state where they don't know if something is finished, which is confusing UX (see http://en.wikipedia.org/wiki/Gulf_of_evaluation). This is also a regression too.

UX - Can you weigh in if this is a blocker from your perspective?

Comment 6

[Stephany Wilkes]

I consider this a blocker. It's a regression, isn't working to spec, and leads the user to believes they are in a state that they are not.

Comment 7

[Joshua Mitchell (Inactive)]

[Blocking Requested - why for this release]: see comment  6

Comment 8

[Peter Bylenga [:PBylenga]]

This also affects facebook import of contacts and is a manual smoketest blocker for https://moztrap.mozilla.org/manage/case/5857/

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

I can see the problem on the console log:

E/GeckoConsole(32596): [JavaScript Error: "ReferenceError: ImportStatusData is not defined" {file: "app://communications.gaiamobile.org/shared/pages/import/gaia_build_defer_import.js" line: 328}]

Comment 11

[Adrián de la Rosa]

I already did a pull request to fix that but I am trying to make a test to prevent this in the future.

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Adrián de la Rosa from comment #11)
> I already did a pull request to fix that but I am trying to make a test to
> prevent this in the future.

Awesome! \o/

That's the spirit!

Comment 13

[Chris Kreinbring [:CKreinbring]]

Regression window
Last working
Build ID: 20140731150609
Gaia: 04ea7e1a4034a50d4a7a4f5b95a04a2ed8313908
Gecko: 104254bd1fc8
Platform Version: 34.0a1
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First broken
Build ID: 20140801070614
Gaia: 9689218473b6fc4dd927ad6aa7b06c05f0843824
Gecko: 8970589d6505
Platform Version: 34.0a1
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Working Gaia / Broken Gecko = No repro
Gaia: 04ea7e1a4034a50d4a7a4f5b95a04a2ed8313908
Gecko: 8970589d6505
Broken Gaia / Working Gecko = Repro
Gaia: 9689218473b6fc4dd927ad6aa7b06c05f0843824
Gecko: 104254bd1fc8
Gaia push log: https://github.com/mozilla-b2g/gaia/compare/04ea7e1a4034a50d4a7a4f5b95a04a2ed8313908...9689218473b6fc4dd927ad6aa7b06c05f0843824

B2G-inbound
Last working
Build ID: 20140731035207
Gaia: 29793743960686ee8d5c4617a36172241c8ae0d0
Gecko: a5fc614872dd
Platform Version: 34.0a1
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First broken
Build ID: 20140801100457
Gaia: 22846bf06d34bd42d124952402ab121e6ae05c27
Gecko: f2acc6ff7aee
Platform Version: 34.0a1
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Working Gaia / Broken Gecko = No repro
Gaia: 29793743960686ee8d5c4617a36172241c8ae0d0
Gecko: f2acc6ff7aee
Broken Gaia / Working Gecko = Repro
Gaia: 22846bf06d34bd42d124952402ab121e6ae05c27
Gecko: a5fc614872dd
Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/29793743960686ee8d5c4617a36172241c8ae0d0...22846bf06d34bd42d124952402ab121e6ae05c27

Unable to get a more refined B2G window due to the builds in between being broken due to bug 1046967.

Comment 14

[Joshua Mitchell (Inactive)]

Jason - I think this might have been broken by bug 1020547 - the dev in question is listed as 'staktrace' but their github page does not have any contact info and Bugzilla does not recognize the name.

Comment 15

[Jason Smith [:jsmith]]

I think you are looking for kats here.

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Is there any particular reason you think bug 1020547 is responsible for this change? I see it in the b2g-inbound regression window but not in the (much smaller) nightly window from comment 13. I think that the regressing bug would show up in both windows. To me bug 1003086 seems much more likely as it directly touches what appears to be contact importing code.

Comment 17

[Joshua Mitchell (Inactive)]

I did not think to use the first push-log - it is VERY rare that our initial Mozilla-Central pushlogs are smaller than the inbound ones and I just wasn't using my brain.
I agree with your assessment about bug 1003086

Comment 18

[Jose Manuel Cantera]

yes, bug 1003086 is the responsible for this regression

thanks

Comment 19

[Adrián de la Rosa]

Attachment: Pull request #22564

Comment 20

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/e91d6a7e24da61764a2bca26dff2e50da0e82c8b

Comment 21

[Ed Morley [:emorley]]

Reverted for failures in link_test.js:
https://tbpl.mozilla.org/php/getParsedLog.php?id=45420190&tree=B2g-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=45421897&tree=B2g-Inbound

These were visible in the gaia-try run that was linked from the PR:
https://tbpl.mozilla.org/?rev=97d43e390a8db6c4545c1ee0300e61066e5399d7&tree=Gaia-Try

Please look at the try results before merging :-)

https://github.com/mozilla-b2g/gaia/commit/f6156186a218b28bd5ebc6ade83e49191e228d4a

Comment 22

[Adrián de la Rosa]

Attachment: Pull request #22661

Comment 23

[Jose Manuel Cantera]

Comment on attachment 8469871 [details]
Pull request #22661

thanks Adrian

Comment 24

[Jose Manuel Cantera]

(In reply to Ed Morley [:edmorley] from comment #21)
> Reverted for failures in link_test.js:
> https://tbpl.mozilla.org/php/getParsedLog.php?id=45420190&tree=B2g-Inbound
> https://tbpl.mozilla.org/php/getParsedLog.php?id=45421897&tree=B2g-Inbound
> 
> These were visible in the gaia-try run that was linked from the PR:
> https://tbpl.mozilla.org/
> ?rev=97d43e390a8db6c4545c1ee0300e61066e5399d7&tree=Gaia-Try
> 
> Please look at the try results before merging :-)
> 
> https://github.com/mozilla-b2g/gaia/commit/
> f6156186a218b28bd5ebc6ade83e49191e228d4a

yes my fault, sorry for the inconvenience :)

Comment 25

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/1826e292646dff4c805d4b6d049e578bbbce6066

Comment 26

[Josh Schmitt [Joshs]]

This issue no longer repros on 2.1 Flame

The page disappears as expected after importing contacts.

Environmental Variables:
Device: Flame Master 319MB
Build ID: 20140811040202
Gaia: 19ed3c9e78eaf234cc08484bde6998ae21552ba5
Gecko: a9b43778f0c2
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 27

[bhavana bajaj [:bajaj]]

Switching the 2.1?->2.1+, on these fixed bugs as these are regression.

Nothing to land here, its just flag-cleanup of 2.1? list. Please Ni me if there is confusion/disagreement.