1048178 - Can't drag thumb after right click while scrolling

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Aleksandr Seleznev]

I can reproduce it under Linux and MS Windows with `ui.scrollToClick`=0.

How to reproduce:

1. Open any good long page.
2. Put cursor on scrollbar (but not on the thumb). For ex, at the end of
   scrollbar.
3. Press and hold left mouse button.
4. Do right click (on any place of the screen).
5. Release left mouse button.
6. Try to drag the thumb by left mouse button.

NOTE: Between 3 and 4 steps you can to move mouse.

Expected result:

- You can drag the thumb.

Actual result:

- Thumb has :active state but doesn't follow to mouse.

Comment 1

[Aleksandr Seleznev]

Attachment: fix-stop-scrolling-by-right-click.patch

It works for me. Tested under GNU/Linux.

Changes:

1. Added nsSliderFrame::mDragFinished property. It should help to detect mouse
   buttons clicks after starting scrolling. It's needed because
   nsSliderFrame::isDraggingThumb() return false after every
   NS_MOUSE_BUTTON_DOWN events. And as result, scrolling can be not stopped
   completely.

2. Moved some code to nsSliderFrame::StopDrag() method.

I'm not check event type in following code because I'm not sure, that is
really required.

> if (!mDragFinished && !isDraggingThumb()) {
>   StopDrag();
>   return NS_OK;
> }

Comment 2

[Aleksandr Seleznev]

Comment on attachment 8466980 [details] [diff] [review]
fix-stop-scrolling-by-right-click.patch

I ask you review because you already reviewed 1-2 parts in bug 803633, and
this issue blocks bug 803633.

Sorry for noise in any case. :(

Comment 3

[Aleksandr Seleznev]

It looks like bug 72776, but isn't "enhancement".

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8466980 [details] [diff] [review]
fix-stop-scrolling-by-right-click.patch

Review of attachment 8466980 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 5

[Aleksandr Seleznev]

Attachment: add-test.patch

+ toolkit/content/tests/chrome/test_bug1048178.xul
~ toolkit/content/tests/chrome/chrome.ini

Not sure that is really required.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Do you happen to have a Try link handy? If not, maybe Markus can help.

Comment 7

[Markus Stange [:mstange]]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=69dac3a63e97

Comment 8

[Markus Stange [:mstange]]

Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0109149eba1
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a7d3b7aaa05

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c0109149eba1
https://hg.mozilla.org/mozilla-central/rev/7a7d3b7aaa05