1048352 - All alarms get enabled when app is opened

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Gregor Wagner [:gwagner]]

If I open the clock app, every single alarm gets activated and the bell sign shows up in the status bar.

Comment 1

[Gregor Wagner [:gwagner]]

I can show you on my device if you can't reproduce. This is pretty annoying :)

Comment 2

[Marcus Cavanaugh [:mcav]]

Initial investigation shows that this is cosmetic only, i.e. the alarms are not actually reenabled on startup. Similarly, the bell icon is controlled by Clock and also incorrectly displayed.

Comment 3

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22794

Comment 4

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8471762 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22794

The 'untoggle an alarm' action previously didn't persist the alarm IndexedDB representation (though it did remove the mozAlarm).

Comment 5

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8471762 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22794

LGTM. changes are minimal (logic is basically the same) but now it waits for the promises to resolve and persists the data to the DB.

Comment 6

[Marcus Cavanaugh [:mcav]]

master: https://github.com/mozilla-b2g/gaia/commit/1a6282f433f87031e62fe1bf0a79992e8d30ac17

Comment 7

[Edward Chen[:edchen]]

Hi Marcus,Miller

I would like to confirm one thing because I found a bug but I am not sure this bug if its side effect for this ticket.

When user set up a new alarm, actually the bell icon has to show up in the status bar, but I can see it now. Could you double check this situation. If this is not a side effect I will mark this ticket to RESOLVED and then file a new bug.

[Environment]
Gaia      3584b2723412ed3299c6761f465885d80651c87e
Gecko     https://hg.mozilla.org/mozilla-central/rev/e7806c9c83f3
BuildID   20140820160201
Version   34.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

Comment 8

[Edward Chen[:edchen]]

[Environment]
Gaia      e424c85eda87a40c0fa64d6a779c3fa368bf770b
Gecko     https://hg.mozilla.org/mozilla-central/rev/daa84204a11a
BuildID   20140824160205
Version   34.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014


[Result]
I refresh a new build today, above issue has not occurs. I marked it to VERIFIED.