1055229 - [B2G][Clock] Clock icon does not reappear when hitting snooze

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Seth Miko [:SMiko]]

Attachment: Alarm.txt

Description:
Hitting snooze on a ringing alarm does not cause the alarm icon to appear on the status bar.

Repro Steps:
1) Update a Flame to 20140818040201
2) Open Clock and create a new alarm (alarm icon appears on the status bar)
3) When the alarm sounds (alarm icon disappears from status bar), tap the "snooze" button

Actual:
The alarm icon does not reappear

Expected:
The alarm icon reappears

Flame 2.1 (319mb)

Environmental Variables:
Device: Flame Master (319mb)
Build ID: 20140818040201
Gaia: aa8aace12d65956dd9525da5dac66e0d3b28597f
Gecko: 0aaa2d3d15cc
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Keywords:
clock, alarm, snooze, ring, icon, status bar, 

Repro frequency:100%

Link to failed test case: https://moztrap.mozilla.org/manage/case/4477/

See attached: logcat 

Video clip: http://youtu.be/IDXlPDDnSO4

Comment 1

[Seth Miko [:SMiko]]

This issue DOES repro on Flame 2.1 (512mb) and Buri 2.1

Actual Result:
Hitting snooze on a ringing alarm does not cause the alarm icon to appear on the status bar.

Flame 2.1 (512mb)

Environmental Variables:
Device: Flame Master (512mb)
Build ID: 20140818040201
Gaia: aa8aace12d65956dd9525da5dac66e0d3b28597f
Gecko: 0aaa2d3d15cc
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.

Buri 2.1

Environmental Variables:
Device: Buri 2.1 Master
BuildID: 20140818073016
Gaia: ba1992f2addc5a84afc2eab426f222a6bf2962ba
Gecko: bf27e27c994d
Version: 34.0a1 (2.1 Master)
Firmware: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

This issue does NOT occur on Flame 2.0 (319mb) or Buri 2.0

Flame 2.0 (319mb)

Device: Flame 2.0 (319mb)
BuildID: 20140818000201
Gaia: fb2dd31abed2803eb7ad67eb4c52abb48de1e0f7
Gecko: 09f7a7184c71
Version: 32.0 (2.0) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Buri 2.0

Environmental Variables:
Device: Buri 2.0
Build ID: 20140818063008
Gaia: 640ce38ca03f1e26a4524ff4215b8b3f7731e2f0
Gecko: 692c93509dc9
Version: 32.0 (2.0)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

This was working fine on 2.0 and is now broken on 2.1. The user should be able to tell in the status bar when the alarm is active so nominating 2.1?

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20140812145714
Gaia: 2f05c9c2a10d45f91e1094246d43c5fda57c4e99
Gecko: 95f2da32927e
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20140812151214
Gaia: 1a6282f433f87031e62fe1bf0a79992e8d30ac17
Gecko: dd06402ee662
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First broken gecko & last working gaia - issue does NOT repro
Gaia: 2f05c9c2a10d45f91e1094246d43c5fda57c4e99
Gecko: dd06402ee662

First broken gaia & last working gecko - issue DOES repro
Gaia: 1a6282f433f87031e62fe1bf0a79992e8d30ac17
Gecko: 95f2da32927e

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/2f05c9c2a10d45f91e1094246d43c5fda57c4e99...1a6282f433f87031e62fe1bf0a79992e8d30ac17

Caused by Bug 1048352.

Comment 4

[Joshua Mitchell (Inactive)]

Broken by  Bug 1048352 ? Can you take a look Marcus?

Comment 5

[Candice Serran (:cserran)]

blocking justification: regression needs to be fixed

Comment 6

[Joshua Mitchell (Inactive)]

Jason -  my NI to the regression patch author is over 2 weeks old - can you redirect to someone active?

Comment 7

[Joshua Mitchell (Inactive)]

oops, clearing unnecessary need-info flag

Comment 8

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24069

Comment 9

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8489705 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24069

small changes, documented and with unit tests to avoid regressions. nice work!

Comment 10

[Marcus Cavanaugh [:mcav]]

Thanks, Miller.

master: https://github.com/mozilla-b2g/gaia/commit/846ec05dcbfdd8ba106c5e1f5455db84d0b03634

Comment 11

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8489705 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24069

[Approval Request Comment]

Requesting approval for v2.1; without this minimal patch, users would be misled by the system statusbar alarm icon being hidden when an alarm was actually scheduled to snooze. Low risk, tested with manual+automatic verification.


[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/485336a8027ea1b93fabe393bad8b90ad8153712

Comment 13

[Edward Chen[:edchen]]

[Environment]
Gaia-Rev        b3f9b97d16a1ab55f80239d63c1a85c3da3d39ad
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/2c6e3261c47b
Build ID        20140921160204
Version         34.0a2
Device Name     flame
FW-Release      4.3
FW-Incremental  110
FW-Date         Fri Jun 27 15:57:58 CST 2014
Bootloader      L1TC00011230

[Result]
PASS

Comment 14

[pete siphantong [:Petes]]

This bug is verified fixed on the Flame 2.1 (319mb) and the Flame 2.2 (319mb)


Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.1
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Result: The alarm icon reappears when user taps the snooze button