Closed
Bug 1048375
Opened 10 years ago
Closed 10 years ago
browser_aboutHome.js intermittently causes external requests to snippets.mozilla.com
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox32 | --- | fixed |
| firefox33 | --- | fixed |
| firefox34 | --- | fixed |
| firefox-esr24 | --- | unaffected |
| firefox-esr31 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(1 file)
|
3.69 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
With the patch from bug 1029148 applied, this is intermittent locally, but failing consistently on the try server (https://tbpl.mozilla.org/?tree=Try&rev=7930d58a0081). AboutHomeUtils.snippetsURL is a lazy getter, so if it's called for the first time before the test has started and changed the value of the pref, the test causes external network requests.
Flags: firefox-backlog+
|
Assignee | |
Comment 1•10 years ago
|
||
Try is looking green: https://tbpl.mozilla.org/?tree=Try&rev=36da47545266 (but no Windows results yet).
Attachment #8467173 -
Flags: review?(gavin.sharp)
|
||
Updated•10 years ago
|
Iteration: --- → 34.1
OS: Mac OS X → All
Hardware: x86 → All
|
|
||
Updated•10 years ago
|
Attachment #8467173 -
Flags: review?(gavin.sharp) → review+
|
||
Updated•10 years ago
|
Status: NEW → ASSIGNED
QA Whiteboard: [qa?]
|
|
Assignee | |
Updated•10 years ago
|
QA Whiteboard: [qa?] → [qa-]
|
|
||
Updated•10 years ago
|
Iteration: 34.1 → 34.2
|
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/5d3084f4f861
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5d3084f4f861
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/781d772a1f14 https://hg.mozilla.org/releases/mozilla-beta/rev/8e09aad61a79 https://hg.mozilla.org/releases/mozilla-esr31/rev/a748e58068cf
status-firefox32:
--- → fixed
status-firefox33:
--- → fixed
status-firefox34:
--- → fixed
status-firefox-esr24:
--- → unaffected
status-firefox-esr31:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•