Closed Bug 1048375 Opened 6 years ago Closed 6 years ago
_about Home .js intermittently causes external requests to snippets .mozilla .com
With the patch from bug 1029148 applied, this is intermittent locally, but failing consistently on the try server (https://tbpl.mozilla.org/?tree=Try&rev=7930d58a0081). AboutHomeUtils.snippetsURL is a lazy getter, so if it's called for the first time before the test has started and changed the value of the pref, the test causes external network requests.
Try is looking green: https://tbpl.mozilla.org/?tree=Try&rev=36da47545266 (but no Windows results yet).
Attachment #8467173 - Flags: review?(gavin.sharp)
Iteration: --- → 34.1
OS: Mac OS X → All
Hardware: x86 → All
Attachment #8467173 - Flags: review?(gavin.sharp) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
You need to log in before you can comment on or make changes to this bug.