1048395 - Missing search activity resource errors in Eclipse

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Brian Nicholson (:bnicholson)]

Running Fennec from Eclipse currently fails with the following aapt errors:

Description	Resource	Path	Location	Type
error: Error: No resource found that matches the given name (at 'theme' with value '@style/AppTheme').	AndroidManifest.xml	/Fennec	line 1557	Android AAPT Problem
error: Error: No resource found that matches the given name (at 'icon' with value '@drawable/search_launcher').	AndroidManifest.xml	/Fennec	line 1557	Android AAPT Problem
error: Error: No resource found that matches the given name (at 'logo' with value '@drawable/search_launcher').	AndroidManifest.xml	/Fennec	line 1595	Android AAPT Problem
error: Error: No resource found that matches the given name (at 'resource' with value '@xml/search_widget_info').	AndroidManifest.xml	/Fennec	line 1592	Android AAPT Problem
error: Error: No resource found that matches the given name (at 'theme' with value '@style/SettingsTheme').	AndroidManifest.xml	/Fennec	line 1595	Android AAPT Problem

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: (WIP) Add FennecResourcesSearch dependency to Fennec project

This gets rid of the Eclipse errors, but running from Eclipse crashes on startup with this exception:

08-04 12:28:26.963: E/GeckoAppShell(4337): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
08-04 12:28:26.963: E/GeckoAppShell(4337): android.content.res.Resources$NotFoundException: Resource ID #0x7f08003d
08-04 12:28:26.963: E/GeckoAppShell(4337): 	at android.content.res.Resources.getValue(Resources.java:1134)
08-04 12:28:26.963: E/GeckoAppShell(4337): 	at android.content.res.Resources.getDimensionPixelSize(Resources.java:629)
...

What else is missing?

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8467271 [details] [diff] [review]
(WIP) Add FennecResourcesSearch dependency to Fennec project

Review of attachment 8467271 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/moz.build
@@ +707,5 @@
> +    searchactivity.package_name = 'org.mozilla.fennec.resources.search'
> +    searchactivity.res = SRCDIR + '/../search/res'
> +    searchactivity.included_projects += ['../' + resources.name]
> +
> +    main.included_projects += ['../' + searchactivity.name]

https://bug1024708.bugzilla.mozilla.org/attachment.cgi?id=8450632

also has 

  main.referenced_projects += ...

and changes in the moz.build file for the activity. Take a look?

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8467271 [details] [diff] [review]
(WIP) Add FennecResourcesSearch dependency to Fennec project

Landing with rnewman's r+ via IRC. Not a complete solution since running is broken, but this at least fixes the errors inside Eclipse.

https://hg.mozilla.org/integration/fx-team/rev/f50a4c086169

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f50a4c086169

Comment 5

[Nick Alexander :nalexander [he/him]]

I saw this once before I left, and chased it pretty far to understand what was happening.  I believe that recent versions of aapt depend on the order of the resource directories on the command line.  There's no real way to control this in Eclipse -- it depends on the dependencies between modules -- and it's delicate to make the moz.build system do the exact same thing.

The underlying issue is that the org.mozilla.gecko.R that Eclipse builds with is generated by the moz.build system, not by Eclipse itself.  I am going to investigate whether we can separate the $OBJDIR/m/a/b/generated directory into the aapt-generated pieces and the preprocessed pieces, and, in Eclipse only, build the aapt-generated using Eclipse's mechanism.  This should address the issue, and avoid similar problems that occur when building with Android Studio.