Closed Bug 1048459 Opened 10 years ago Closed 10 years ago

[research] check if updating from a tarball in a virtual environment with peep removes files

Categories

(Input Graveyard :: Code Quality, defect)

Product:
Input Graveyard
Component:
Code Quality
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

References

Details

(Whiteboard: u=dev c=codequality p=2 s=input.2014q3) 

We had a couple of instances where stray .py and .pyc files were in vendor/ which caused problems when we deployed updates to those libraries.

When we switch from our current vendor/ (which is all checked into git) to a vendor/ generated by peep, we need to make sure that when we update libraries and remove libraries that there's no cruft left behind.

This bug covers that.
Fixing the depends/blocks.
No longer blocks: 987801, 1048461
Depends on: 987801
I did the research work for this when updating elasticutils for kitsune (bug #1071565). I hit an issue where if you switch from a github-tarball based requirement to a wheel, pip didn't uninstall the existing package. That's covered in bug #1074861.

To fix that, I added --no-use-wheel args to the peep script in fjord in https://github.com/mozilla/fjord/commit/c726b06780cf5b5d9f86b267f1526c0fd57ee6df .

Thus we should be all set here.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee: nobody → willkg
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.