1048603 - [B2G][Contacts] Arabic: Icons are overlapping text when viewing a pre-existing contact

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jordan de Geus(JordanD)]

Attachment: icon.png

Description:
When a users selects on a pre-existing contact, the user will observe the icons for "Link Contact", "Find duplicate contacts", and "Add as Favorite" are overlapping the button text as they are right aligned.

SETUP: 
Settings> Language> Arabic

Repro Steps:
1) Update a Flame to 20140804000204
2) Navigate to Contacts> Press the "+" on the top left corner
3) Add a name to a contact and select "Save" on the top corner
4) Select the newly saved contact and observe the icons overlap the text

Actual:
When viewing preexisting contacts, users can observe icons overlap text

Expected:
Icons when viewing pre-existing contacts display correctly

Environmental Variables:
Device: Flame 2.0 (319mb)
Build ID: 20140804000204
Gaia: 9e5907995c9327f14cb5d182cee5ff16b1743ed4
Gecko: 3f7db58a354c
Version: 32.0 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Repro frequency: 3/3
Link to failed test case: 
See attached: Screenshot - Icon.png

Comment 1

[Jordan de Geus(JordanD)]

This DOES occur on Flame 2.1 (319mb), Flame 2.0 (512mb), Buri 2.1, and Buri 2.0

Actual: Users will see the icons aligned right causing the icon to overlap button text

Flame 2.1 (319mb)

Environmental Variables:
Device: Flame Master
Build ID: 20140801040326
Gaia: 04ea7e1a4034a50d4a7a4f5b95a04a2ed8313908
Gecko: 104254bd1fc8
Version: 34.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.0 (512mb)

Environmental Variables:
Device: Flame 2.0
Build ID: 20140804000204
Gaia: 9e5907995c9327f14cb5d182cee5ff16b1743ed4
Gecko: 3f7db58a354c
Version: 32.0 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Buri 2.1

Environmental Variables:
Device: Buri Master
Build ID: 20140730073003
Gaia: 25e998814ba89f30fe44cd2fdfbb44d160a04641
Gecko: 08c23f12a43e
Version: 34.0a1 (Master)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Buri 2.0

Environmental Variables:
Device: Buri 2.0
Build ID: 20140730063007
Gaia: 2e85678de2c8e13e585288d4cec7d6673cee17ee
Gecko: 2b6108c94b2e
Version: 32.0 (2.0)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

----------------------------------------------------------------------------------------
This DOES NOT occur on  Flame 1.4 (319mb), Buri 1.4

Actual: Icon does not overlap the text as it is aligned left

Flame 1.4 (319mb)

Environmental Variables:
Device: Flame 1.4
Build ID: 20140804063202
Gaia: 9377274b17200a60cebcd2427d489a7756c4cc72
Gecko: 93e736da9863
Version: 30.0 (1.4)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Buri 1.4

Environmental Variables:
Device: Buri 1.4
Build ID: 20140730063005
Gaia: 142953262d2cb031e3db217206edc3507580b0df
Gecko: 17de7b9d035c
Version: 30.0 (1.4)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Minor regression from 1.4 so not nominating 2.0? but should be fixed for release cause it looks bad.

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

[Blocking Requested - why for this release]:

Nominating for 2.1
Reason: Arabic is a shipping locale

Comment 4

[Ahmed Nefzaoui [:Nefzaoui]]

I've just verified that this bug has been fixed after landing a patch from Bug 1037607.

Comment 5

[Stephany Wilkes]

Marking this resolved fixed based on Ahmed's comment #4, then. Thanks Ahmed! Delphine was correct with the 2.1 blocking call, for the record.

Comment 6

[bhavana bajaj [:bajaj]]

Switching the 2.1?->2.1+, on these fixed bugs as these are regression.

Nothing to land here, its just flag-cleanup of 2.1? list. Please Ni me if there is confusion/disagreement.

Comment 7

[Seth Miko [:SMiko]]

Verified fixed on Flame 2.2 (319mb/full flash) and Flame 2.1 (319mb/full flash)

Actual result: overlapping text is not present when viewing existing contacts in Arabic.

Device: Flame 2.2
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame 2.1
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
_______________________________________________________________________________________________________________________________

This issue still occurs on Flame 2.0 (319mb/full flash)

Actual result: When viewing preexisting contacts, users can observe icons overlap text

Device: Flame 2.0
BuildID: 20141012000202
Gaia: 6effca669c5baaf6cd7a63c91b71a02c6bd953b3
Gecko: 54ec9cb26b59
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
_______________________________________________________________________________________________________________________________
Awaiting uplift for 2.0

Leaving verifyme keyword for 2.0 verification.

Comment 8

[Seth Miko [:SMiko]]

Created bug 1082215 for 2.0 tracking.

Comment 9

[Peter Bylenga [:PBylenga]]

Mass Edit: adding the [rtl-meta]