Closed Bug 1048629 Opened 5 years ago Closed 5 years ago

Remove HAIDA flag

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S2 (15aug)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

We no longer need this flag as we are enabling features as we land them. Let's update the preference that task manager uses though.
It looks like we also have a new 'in-app-sheet.enabled' preference which we should remove. I don't think this necessarily needs a build flag for though, so perhaps this can move to the settings app if we still need it, or just change the behavior for 2.1.
Alive - Ni? on you to see if we can turn in-app-sheet.enabled to true in 2.1.
Flags: needinfo?(alive)
(In reply to Kevin Grandon :kgrandon from comment #2)
> Alive - Ni? on you to see if we can turn in-app-sheet.enabled to true in 2.1.

Let's turn it off by default. That's in app sheet and I am not told it's 2.1 feature
Flags: needinfo?(alive)
Comment on attachment 8467445 [details] [review]
Pull request - remove rocketbar.enabled setting

Hey Yuren and Sam - I think you guys would make good reviewers for this. Could you take a look? Thanks!
Attachment #8467445 - Flags: review?(yurenju.mozilla)
Attachment #8467445 - Flags: review?(sfoster)
Comment on attachment 8467445 [details] [review]
Pull request - remove rocketbar.enabled setting

Thanks for doing this, just the one nit in GH to s/isRocketbar/isTaskStrip for consistency. Assuming tests pass it looks good to me. You'll need Alive or another systems app peer to r+ though
Attachment #8467445 - Flags: review?(sfoster) → feedback+
Comment on attachment 8467445 [details] [review]
Pull request - remove rocketbar.enabled setting

Alive/Vivien - Could either one of you look at the system part? Thanks!
Attachment #8467445 - Flags: review?(alive)
Attachment #8467445 - Flags: review?(21)
Comment on attachment 8467445 [details] [review]
Pull request - remove rocketbar.enabled setting

looks good.
Attachment #8467445 - Flags: review?(yurenju.mozilla) → review+
Comment on attachment 8467445 [details] [review]
Pull request - remove rocketbar.enabled setting

Not sure why not removing the in-app-sheet.enabled?
Attachment #8467445 - Flags: review?(alive) → review+
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #9)
> Not sure why not removing the in-app-sheet.enabled?

The goal is to very quickly remove HAIDA=1. In this case, I don't see much use in a build-time solution for this pref. Let's use custom-settings for a build-time solution, or otherwise implement a setting in the settings app. Does that work for you?
Attachment #8467445 - Flags: review?(21)
Sam - the same goes for the new setting, 'taskstrip.enabled'. To enable it you'll either have to implement some simple UI in settings (depending on timeframe this may or may not make sense), or locally implement some JSON in custom-settings.json. We can use this to test both prefs:

{
  "taskstrip.enabled": true
}

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #9)
> Comment on attachment 8467445 [details] [review]
> Pull request - remove rocketbar.enabled setting
> 
> Not sure why not removing the in-app-sheet.enabled?

Actually I mis-read your comment. Let's remove it, and use custom-settings if you're fine with it. Thanks!
Master: https://github.com/mozilla-b2g/gaia/commit/ed4d056d92fe7c20f265f1cbbe07521d55742f5c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.