1048819 - mozilla-b2g30_v1_4 & mozilla-b2g28_v1_3 Hamachi nightlies failing with "build-flash-fota.py: error: argument -s/--sdk-version is required", "make: *** [out/target/product/hamachi/fota/partial/update.zip] Error 2"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Ed Morley [:emorley]]

See:
https://tbpl.mozilla.org/?tree=Mozilla-B2g30-v1.4&jobname=hamachi&fromchange=dbba6bee8242&tochange=tip

eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=45210725&tree=Mozilla-B2g30-v1.4#error5

{
18:50:29     INFO -  Using yaffs2 filesystem
18:50:29     INFO -  No recovery, but not Ext FS
18:50:29     INFO -  Mounting /system from "system"
18:50:29     INFO -  Mounting /data   from "userdata"
18:50:29     INFO -  Generating FOTA update package
18:50:29     INFO -  mkdir -p `dirname out/target/product/hamachi/fota/partial/update.zip` || true
18:50:29     INFO -  usage: build-flash-fota.py [options]
18:50:29     INFO -  build-flash-fota.py: error: argument -s/--sdk-version is required
18:50:29     INFO -  make: *** [out/target/product/hamachi/fota/partial/update.zip] Error 2
}

mozilla-b2g30_v1_4 is closed due to this.

Comment 1

[Gabriele Svelto [:gsvelto] (PTO)]

This is a consequence of bug 1047350. I think this should be fixable by uplifting attachment 8466225 [details] [review] to v1.4, could you try that out? If it fixes the problem we can proceed uplifting immediately since the original bug is required for v1.4. I'm NI'ing :gerard-majax for the uplift.

Comment 2

[Ed Morley [:emorley]]

Thank you for tracking this down.
I've filed bug 1048854 for making the B2G bumper bot handle these repos too - since having no gecko-facing commit for them is pretty frustrating.

Comment 3

[Ed Morley [:emorley]]

Ah, it seems like the gonk-misc revision is pinned in sources.xml via b2g-manifest master (and thus release branches won't get it), whereas it mozilla-b2g/B2G isn't handled at all by sources.xml and so we pull in master indiscriminately (bug 1048854 will fix this).

Comment 4

[:gerard-majax]

Attachment: B2G PR to make the option non mandatory

By making the option non mandatory and defaulting to ICS we should avoid breakage because of code calling without --sdk-version.

Comment 5

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8467725 [details] [review]
B2G PR to make the option non mandatory

Tested on a v1.4 Hamachi builds and working fine. Sorry for the inconvenience here; the blame is on me as in the original review I forgot about the unversioned nature of the B2G repo and the impact that making the --sdk-version parameter would have on the other branches.

Comment 6

[:gerard-majax]

https://github.com/mozilla-b2g/B2G/commit/d5d94b8b5c5bace3812b6803ddd92def5c08491b

Comment 7

[Ed Morley [:emorley]]

Thank you - I've retriggered the nightlies on mozilla-b2g30_v1_4 & mozilla-b2g28_v1_3.