mozilla-b2g30_v1_4 & mozilla-b2g28_v1_3 Hamachi nightlies failing with "build-flash-fota.py: error: argument -s/--sdk-version is required", "make: *** [out/target/product/hamachi/fota/partial/update.zip] Error 2"

RESOLVED FIXED in 2.1 S2 (15aug)

Status

Firefox OS
GonkIntegration
--
blocker
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: emorley, Assigned: gerard)

Tracking

unspecified
2.1 S2 (15aug)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
See:
https://tbpl.mozilla.org/?tree=Mozilla-B2g30-v1.4&jobname=hamachi&fromchange=dbba6bee8242&tochange=tip

eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=45210725&tree=Mozilla-B2g30-v1.4#error5

{
18:50:29     INFO -  Using yaffs2 filesystem
18:50:29     INFO -  No recovery, but not Ext FS
18:50:29     INFO -  Mounting /system from "system"
18:50:29     INFO -  Mounting /data   from "userdata"
18:50:29     INFO -  Generating FOTA update package
18:50:29     INFO -  mkdir -p `dirname out/target/product/hamachi/fota/partial/update.zip` || true
18:50:29     INFO -  usage: build-flash-fota.py [options]
18:50:29     INFO -  build-flash-fota.py: error: argument -s/--sdk-version is required
18:50:29     INFO -  make: *** [out/target/product/hamachi/fota/partial/update.zip] Error 2
}

mozilla-b2g30_v1_4 is closed due to this.
This is a consequence of bug 1047350. I think this should be fixable by uplifting attachment 8466225 [details] [review] to v1.4, could you try that out? If it fixes the problem we can proceed uplifting immediately since the original bug is required for v1.4. I'm NI'ing :gerard-majax for the uplift.
Flags: needinfo?(lissyx+mozillians)
(Reporter)

Comment 2

4 years ago
Thank you for tracking this down.
I've filed bug 1048854 for making the B2G bumper bot handle these repos too - since having no gecko-facing commit for them is pretty frustrating.
(Reporter)

Comment 3

4 years ago
Ah, it seems like the gonk-misc revision is pinned in sources.xml via b2g-manifest master (and thus release branches won't get it), whereas it mozilla-b2g/B2G isn't handled at all by sources.xml and so we pull in master indiscriminately (bug 1048854 will fix this).
(Reporter)

Updated

4 years ago
Blocks: 1047350
(Assignee)

Comment 4

4 years ago
Created attachment 8467725 [details] [review]
B2G PR to make the option non mandatory

By making the option non mandatory and defaulting to ICS we should avoid breakage because of code calling without --sdk-version.
Assignee: nobody → lissyx+mozillians
Attachment #8467725 - Flags: review?(gsvelto)
Flags: needinfo?(lissyx+mozillians)
(Reporter)

Updated

4 years ago
Summary: mozilla-b2g30_v1_4 Hamachi nightlies failing with "build-flash-fota.py: error: argument -s/--sdk-version is required", "make: *** [out/target/product/hamachi/fota/partial/update.zip] Error 2" → mozilla-b2g30_v1_4 & mozilla-b2g28_v1_3 Hamachi nightlies failing with "build-flash-fota.py: error: argument -s/--sdk-version is required", "make: *** [out/target/product/hamachi/fota/partial/update.zip] Error 2"
Comment on attachment 8467725 [details] [review]
B2G PR to make the option non mandatory

Tested on a v1.4 Hamachi builds and working fine. Sorry for the inconvenience here; the blame is on me as in the original review I forgot about the unversioned nature of the B2G repo and the impact that making the --sdk-version parameter would have on the other branches.
Attachment #8467725 - Flags: review?(gsvelto) → review+
(Assignee)

Comment 6

4 years ago
https://github.com/mozilla-b2g/B2G/commit/d5d94b8b5c5bace3812b6803ddd92def5c08491b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

4 years ago
Thank you - I've retriggered the nightlies on mozilla-b2g30_v1_4 & mozilla-b2g28_v1_3.
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S2 (15aug)
You need to log in before you can comment on or make changes to this bug.