1048903 - Change TabCounter to take layout id as an attribute

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

So that we can vary the inner layouts if/when we need.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Change TabCounter to take layout id as attribute (r=wesj)

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8467789 [details] [diff] [review]
Change TabCounter to take layout id as attribute (r=wesj)

This doesn't change anything in the existing behaviour. This is only to enable us to vary the inner layout in the new tablet UI.

I'll land this patch straight into m-c.

Comment 3

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/87a627775f0b

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/87a627775f0b

Comment 5

[Mark Capella [:capella]]

Was this supposed to happen?
https://www.dropbox.com/s/af10k0til1jopi0/Screenshot_2014-08-11-19-50-57.png

:-D Backout this patch and it looks nice again.

Comment 6

[Lucas Rocha (:lucasr)]

(In reply to Mark Capella [:capella] from comment #5)
> Was this supposed to happen?
> https://www.dropbox.com/s/af10k0til1jopi0/Screenshot_2014-08-11-19-50-57.png
> 
> :-D Backout this patch and it looks nice again.

Ugh, looks like a regression indeed. Filed bug 1052345 to track this. Thanks!