Closed Bug 1048907 Opened 7 years ago Closed 7 years ago

Cast tabs button to ThemedImageButton instead of ShapedButton

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 34

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(1 file)

Cast tabs button to ThemedImageButton (r=mcomella)
2.01 KB, patch
mcomella
: review+
Details | Diff | Splinter Review 
As it won't be a ShapedButton in the new tablet UI.
Comment on attachment 8467785 [details] [diff] [review]
Cast tabs button to ThemedImageButton (r=mcomella)

This will land straight into m-c btw.
Attachment #8467785 - Flags: review?(michael.l.comella)
Comment on attachment 8467785 [details] [diff] [review]
Cast tabs button to ThemedImageButton (r=mcomella)

Review of attachment 8467785 [details] [diff] [review]:
-----------------------------------------------------------------

nit: I believe you should be able to remove the ShapedButton import too.
Attachment #8467785 - Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/mozilla-central/rev/6b5f65e66fd1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.