Cast tabs button to ThemedImageButton instead of ShapedButton

RESOLVED FIXED in Firefox 34

Status

()

Firefox for Android
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
Firefox 34
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
As it won't be a ShapedButton in the new tablet UI.
(Assignee)

Comment 1

4 years ago
Created attachment 8467785 [details] [diff] [review]
Cast tabs button to ThemedImageButton (r=mcomella)
(Assignee)

Comment 2

4 years ago
Comment on attachment 8467785 [details] [diff] [review]
Cast tabs button to ThemedImageButton (r=mcomella)

This will land straight into m-c btw.
Attachment #8467785 - Flags: review?(michael.l.comella)
Comment on attachment 8467785 [details] [diff] [review]
Cast tabs button to ThemedImageButton (r=mcomella)

Review of attachment 8467785 [details] [diff] [review]:
-----------------------------------------------------------------

nit: I believe you should be able to remove the ShapedButton import too.
Attachment #8467785 - Flags: review?(michael.l.comella) → review+
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/6b5f65e66fd1
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
You need to log in before you can comment on or make changes to this bug.