Thunderbird Linux and Mac MozMill builders are using the system python (fix bustage on Thunderbird Mac MozMill builders)



Release Engineering
General Automation
3 years ago
3 years ago


(Reporter: standard8, Assigned: standard8)


(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)



(2 attachments)

Created attachment 8467995 [details] [diff] [review]
Possible fix

On Mac, we've just noticed our MozMill builders are running 2.6, and we have bustage because of it.

It appears there's an old bit of code that was introduced when we first ported Thunderbird's MozMill test infrastructure to it.

I'm guessing that the right thing to do here, is to just use 'python' rather than a directory-specific python, and hopefully then buildbot will do the right thing?

I think we're safe to apply this to all branches, as non-Mac already seem to run 2.7.
Attachment #8467995 - Flags: review?(nthomas)
Created attachment 8468003 [details] [diff] [review]
Attempt fix Mac 10.6 xpcshell-test builders as well

Thunderbird also hasn't switched to mozharness yet, and I just realised our 10.6 builders are on python as well. I think if we tweak the path, then it might just do the right thing, though I'm not entirely sure.
Attachment #8468003 - Flags: review?(nthomas)
Comment on attachment 8467995 [details] [diff] [review]
Possible fix

Review of attachment 8467995 [details] [diff] [review]:

Sorry, I hadn't realized this was in mozmill only code and had been trying to see if jetpack was going to barf. *stamp*
Attachment #8467995 - Flags: review?(nthomas) → review+
Comment on attachment 8468003 [details] [diff] [review]
Attempt fix Mac 10.6 xpcshell-test builders as well

Review of attachment 8468003 [details] [diff] [review]:

::: mozilla-tests/
@@ +55,5 @@
>  PLATFORMS['macosx64']['mountainlion'] = {'name': builder_prefix + "Rev5 MacOSX Mountain Lion 10.8"}
>  PLATFORMS['macosx64']['stage_product'] = 'thunderbird'
>  PLATFORMS['macosx64']['mozharness_python'] = '/tools/buildbot/bin/python'
> +# Workaround to get correct python version whilst Thunderbird doesn't have mozharnees
> +PLATFORMS['macosx64']['env']['PATH'] = '/tools/buildbot/bin/python:/tools/python/bin:/tools/buildbot/bin:/opt/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11/bin'

You meant
  PLATFORMS['macosx64']['env']['PATH'] = '/tools/buildbot/bin:/tools/...
and 'mozharness', yes ?  (put executable on the path, and typo respectively). I'll assume so and go with 'r+, please fix on landing'.
Attachment #8468003 - Flags: review?(nthomas) → review+
Comment on attachment 8467995 [details] [diff] [review]
Possible fix
Attachment #8467995 - Flags: checked-in+
Comment on attachment 8468003 [details] [diff] [review]
Attempt fix Mac 10.6 xpcshell-test builders as well

Checked in with comments addressed:
Attachment #8468003 - Flags: checked-in+

Comment 6

3 years ago
I had to back this out:

(tests_scheduler)[ tests_scheduler]$ make checkconfig
cd master && /builds/buildbot/tests_scheduler/bin/buildbot checkconfig
Traceback (most recent call last):
  File "/builds/buildbot/tests_scheduler/lib/python2.7/site-packages/buildbot-0.8.2_hg_8a9e33843c3f_production_0.8-py2.7.egg/buildbot/scripts/", line 1042, in doCheckConfig
  File "/builds/buildbot/tests_scheduler/lib/python2.7/site-packages/buildbot-0.8.2_hg_8a9e33843c3f_production_0.8-py2.7.egg/buildbot/scripts/", line 31, in __init__
    self.loadConfig(configFile, check_synchronously_only=True)
  File "/builds/buildbot/tests_scheduler/lib/python2.7/site-packages/buildbot-0.8.2_hg_8a9e33843c3f_production_0.8-py2.7.egg/buildbot/", line 652, in loadConfig
    exec f in localDict
  File "/builds/buildbot/tests_scheduler/master/master.cfg", line 8, in <module>
    import thunderbird_config
  File "/tmp/tmpfmzxkW/", line 59, in <module>
KeyError: 'env'
make: *** [checkconfig] Error 1

Comment 7

3 years ago
Merged to production, and deployed.
We fixed this enough that we're good for now. There was another bug that disabled 10.6 MozMill builders, pending mozharness transition which is another bug.
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.