104910 - Wrong default for "Don't show this again" checkbox on QuickLaunch dialog

Status: VERIFIED FIXED

(Core Graveyard :: QuickLaunch (AKA turbo mode), defect)

Description

[Bill Law]

The "Don't show me this message again" checkbox on the dialog that appears when
you close the last window while Quick Launch is active is checked by default. 
It should not be.

The current behavior means that the "safe" thing, which is to be warned each
time you close the last window, requires the user to take the precaution of
unchecking that checkbox each and every time the dialog appears.  If they ever
forget, then they will never see this warning again (unless they delete their
profile and create a new one).

At a minimum, the "safe" course should be the default and this checkbox should
be unchecked by default.

This is a one line change to the .xul file for this dialog, at
http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/turboDialog.xul#81

Comment 1

[Blake Ross]

The original reason for why it was changed to default to checked was because we
had solved the privacy issue, so the dialog was really nothing more than a
one-time "here's what's happening with turbo" instructional thing.  However, the
privacy problem has since returned in some forms.  I think this still warrants
more discussion about the proper default once that gets fixed in, perhaps.
(Either default really can't hurt too much).

Comment 2

[Bill Law]

Attachment: The one line fix I described

Comment 3

[Bill Law]

I verified that you can check this checkbox via the keyboard (tab twice, then 
press spacebar).

Need r=, sr= (Blake?), PDT+, etc.

Comment 4

[Paul Chen]

Comment on attachment 53794 [details] [diff] [review]
The one line fix I described

r=pchen

Comment 5

[Blake Ross]

Comment on attachment 53794 [details] [diff] [review]
The one line fix I described

Actually checked should just be removed, with that sr=blake.

Comment 6

[Peter Trudelle]

nsbranch+

Comment 7

[Bill Law]

PDT+ pending positive review, per Jaime.

Comment 8

[Jimmy Lee]

Ccing me since I'm covering Grace while she's out.

Comment 9

[Bill Law]

Fix checked in, branch and trunk.

Comment 10

[Jimmy Lee]

Build: 2001-10-17-05-0.9.4(WIN)

"Don't show me this message again" appears unchecked when starting 6.2 when
installed with Quick Launch active.  If I dismiss this Quick Launch dialog
without checking "Don't show me this message again", then the Quick Launch
dialog no longer appears upon subsequent relaunches with Quick Launch active. 
Is this expected behavior?

If I exit 6.2 without checking "Don't show me this message again", and then I
choose "Exit Netscape 6" from Sys tray, then launching 6.2 does display the
Quick Launch dialog and Quick Launch is enabled again.  Is this expected behavior?

If I exit 6.2 with checking "Don't show me this message again", then subsequent
launches of 6.2 do not display the Quick Launch dialog.  This seems correct to me.

Comment 11

[Jimmy Lee]

Changing me to QA Contact.  Ccing Grace and Lisa.

Comment 12

[Bill Law]

Yes and yes.  The first item is subject of another bug, however (bug 104872).

Comment 13

[Jimmy Lee]

Build: 2001-10-18-06-trunk(WIN)

Trunk works similar to branch.  Bug 104872 will address the one case I pointed
out earlier.  Marking Verified.