1049154 - "Home screen" naming consistency in bookmarks

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

We use a combination of "Homescreen" and "Home Screen" across gaia. We should standardize on "Home Screen" in all contexts.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Pull request - Update collection app

Amir - Could you give this a quick review when you get a chance? Thanks!

Comment 2

[Kevin Grandon :kgrandon]

Attachment: Pull request - Update search app

Amir - Since I already flagged you to this bug, could you look at the search app fixes as well? Thanks!

Comment 3

[Kevin Grandon :kgrandon]

Collection App landed: https://github.com/mozilla-b2g/gaia/commit/1c8e9e7ae03fa5df76c083d101030112ef7067d2
Search App landed: https://github.com/mozilla-b2g/gaia/commit/5e26b687e6fa6a16b995bdeb7abd572632ee502b

Comment 4

[Théo Chevalier]

Actually, it should be "Home screen", and we don't have to update the entity in this particular case (en-US only consistency).

There is more to update, I have a patch for that in bug 1028808 but bug 1038355 needs to be fixed first.

Comment 5

[Kevin Grandon :kgrandon]

(In reply to Théo Chevalier [:tchevalier] from comment #4)
> Actually, it should be "Home screen", and we don't have to update the entity
> in this particular case (en-US only consistency).
> 
> There is more to update, I have a patch for that in bug 1028808 but bug
> 1038355 needs to be fixed first.

Hey Theo - Thanks! I think it was implemented this way because that's what we had in the UX specs, we should get these updated everywhere so we stop making this mistake. I noticed that you're fixing these in bug 1028808, but let me know if there's anything I can do to help. 

I was going to do more here, but I'm glad you've alerted me to that bug :) I don't think we need both of these bugs around, or a meta bug for that matter, so let's just do the work in that one, and we can file additional bugs if there's more to do.