1049217 - crash in java.lang.NoSuchMethodError: android.graphics.Bitmap.getByteCount at org.mozilla.gecko.preferences.LocaleListPreference$CharacterValidator.getPixels(LocaleListPreference.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Locale switching and selection, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:

This bug was filed from the Socorro interface and is 
report bp-cfb1948e-16ef-47c2-8e86-737212140730.
=============================================================

Crash on gingerbread devices doing local switching.

java.lang.NoSuchMethodError: android.graphics.Bitmap.getByteCount
	at org.mozilla.gecko.preferences.LocaleListPreference$CharacterValidator.getPixels(LocaleListPreference.java:62)
	at org.mozilla.gecko.preferences.LocaleListPreference$CharacterValidator.<init>(LocaleListPreference.java:52)
	at org.mozilla.gecko.preferences.LocaleListPreference.<init>(LocaleListPreference.java:85)
	at java.lang.reflect.Constructor.constructNative(Native Method)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:415)
	at android.preference.GenericInflater.createItem(GenericInflater.java:383)
	at android.preference.GenericInflater.createItemFromTag(GenericInflater.java:430)
	at android.preference.GenericInflater.rInflate(GenericInflater.java:481)
	at android.preference.GenericInflater.rInflate(GenericInflater.java:493)
	at android.preference.GenericInflater.inflate(GenericInflater.java:326)
	at android.preference.GenericInflater.inflate(GenericInflater.java:263)
	at android.preference.PreferenceManager.inflateFromResource(PreferenceManager.java:251)
	at android.preference.PreferenceActivity.addPreferencesFromResource(PreferenceActivity.java:262)
	at org.mozilla.gecko.preferences.GeckoPreferences.onCreate(GeckoPreferences.java:338)
	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1047)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1632)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:1684)
	at android.app.ActivityThread.access$1500(ActivityThread.java:124)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:948)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:130)
	at android.app.ActivityThread.main(ActivityThread.java:3717)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:864)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:622)
	at dalvik.system.NativeStart.main(Native Method)

Device list:
motorola 	XT621
samsung 	GT-I9070
samsung 	GT-I8160
                GT-S6500D
Amazon 	        Kindle Fire
samsung 	GT-I9100
samsung 	GT-P1000
TCT 	        ALCATEL ONE TOUCH 4010A
HTC 	        HTC Desire HD A9191
samsung 	SPH-D710
Sony Ericsson 	ST25i
motorola 	XT626
motorola 	XT910

Comment 1

[Richard Newman [:rnewman]]

Added in API 12.

Comment 2

[Richard Newman [:rnewman]]

Attachment: Fix CharacterValidator for API levels below 12

This replaces the API-limited call with one that's safe anywhere, fixes a potential KitKat issue, and also handles a different theoretical problem.

Comment 3

[:Margaret Leibovic]

Comment on attachment 8468122 [details] [diff] [review]
Fix CharacterValidator for API levels below 12

Review of attachment 8468122 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/6a84259b063f

Comment 5

[Nigel Babu [:nigelb]]

Oops, build failure. Do you want to push a fix or backout?

https://tbpl.mozilla.org/php/getParsedLog.php?id=45296039&tree=Fx-Team

Comment 6

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/b79100849d42

Comment 7

[Richard Newman [:rnewman]]

The bustage was because we're building with outdated tools. We might have problems on KitKat devices until Bug 1042829 lands.

I undid the KitKat-specific part of this patch and pushed a fix; when we uplift we need to merge those two.

We should make builder tooling updates routine so that we're not constantly fighting this kind of nonsense. Thanks for your efforts, Wes!

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6a84259b063f
https://hg.mozilla.org/mozilla-central/rev/b79100849d42

Comment 9

[Richard Newman [:rnewman]]

Attachment: Patch for uplift.

AppConstants.Versions doesn't exist on <34, so we'll need this.

Comment 10

[Richard Newman [:rnewman]]

Comment on attachment 8468507 [details] [diff] [review]
Patch for uplift.

Approval Request Comment
[Feature/regressing bug #]:
  Bug 1023451, which worked around an Android limitation in a v12+ way.

[User impact if declined]:
  Crashes in locale picker on API 9-11.

[Describe test coverage new/current, TBPL]:
  None.
 
[Risks and why]: 
  This is a straightforward substitution for the internal implementation of the later method. It also adds a minimal catch for another edge case. Low risk.

[String/UUID change made/needed]:
  None.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/14507a52f09c
https://hg.mozilla.org/releases/mozilla-beta/rev/fc7ce6481ea9

Comment 12

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed on 
Builds:
Firefox for Android 32
Firefox for Android 33
Firefox for Android 34 Beta 1
Device: Samsung Galaxy R (Android 2.3.4)