1049282 - Unable to use gesture typing in search activity

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, defect, P1)

Comment 1

[Eric Edens [:eedens]]

This may be related to how we hide the keyboard's suggestions:

https://lxr.mozilla.org/mozilla-central/source/mobile/android/search/res/layout/clearable_edit_text.xml#13

Whether we want to continue hiding the suggestions is another question :)  --  the original thinking was to conserve some vertical pixels, since we're already getting suggestions over the wire.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Eric Edens [:eedens] from comment #1)
> This may be related to how we hide the keyboard's suggestions:
> 
> https://lxr.mozilla.org/mozilla-central/source/mobile/android/search/res/
> layout/clearable_edit_text.xml#13
> 
> Whether we want to continue hiding the suggestions is another question :) 
> --  the original thinking was to conserve some vertical pixels, since we're
> already getting suggestions over the wire.

I think we've made the wrong trade off here. This breaks the users regular method of text input, slowing them down greatly at the cost of one row of suggestions.

Comment 3

[Eric Edens [:eedens]]

> I think we've made the wrong trade off here. This breaks the users regular
> method of text input, slowing them down greatly at the cost of one row of
> suggestions.

To clarify, which method is 'regular method of text input' referring to? Keyboard suggestions or gesture typing?

If gesture typing, then I agree: we should fix that for sure.

If keyboard suggestions, I think it's normal to hide keyboard's suggestions for search bars. I just tried three apps with search bars (Fennec, Chrome, and the Play Store), and none show the keyboard's suggestions.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Eric Edens [:eedens] from comment #3)
> > I think we've made the wrong trade off here. This breaks the users regular
> > method of text input, slowing them down greatly at the cost of one row of
> > suggestions.
> 
> To clarify, which method is 'regular method of text input' referring to?
> Keyboard suggestions or gesture typing?
> 
> If gesture typing, then I agree: we should fix that for sure.
> 
> If keyboard suggestions, I think it's normal to hide keyboard's suggestions
> for search bars. I just tried three apps with search bars (Fennec, Chrome,
> and the Play Store), and none show the keyboard's suggestions.

The gesture typing specifically, but I also disagree with removing suggestions as well. You can see my comments in the Fenenc bug that disabled suggestions as to why.

Comment 6

[Eric Edens [:eedens]]

Attachment: bug-1049282-fix.patch

Confirmed gesture typing works with Google's keyboard and Swiftkey. (Swiftkey shows a suggestion bar, Google does not).

The `textVisiblePassword` was a hack -- one of the older test phones showed suggestions regardless of the `textNoSuggestions` flag. Clearly, though, it had the unintended consequence of killing suggestions.

On the question of whether or not to suppress suggestions -- if people think that's important, we can open another bug. :) 

PR: https://github.com/mozilla/fennec-search/pull/56

Comment 7

[:Margaret Leibovic]

Comment on attachment 8471674 [details] [diff] [review]
bug-1049282-fix.patch

Review of attachment 8471674 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I think we should get some UX feedback about suggestions.

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

This might fix bug 1050614 too.

Comment 9

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/9631886da333
https://github.com/mozilla/fennec-search/commit/88141dfefbc0deb740cf9f4fd81b52dd604082d6

Comment 10

[:Margaret Leibovic]

(In reply to :Margaret Leibovic from comment #7)
> Comment on attachment 8471674 [details] [diff] [review]
> bug-1049282-fix.patch
> 
> Review of attachment 8471674 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good. I think we should get some UX feedback about suggestions.

After speaking with Eric, I realized that this matches what we currently do for Fennec's location bar, so I'm fine with just maintaining consistency for now.

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9631886da333