104973 - Port |Bug 431217 - Send button should be disabled until we have a recipient| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Composition, enhancement)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build:  Current trunk CVS, Windows 2000 (but applies to all OSs)

Summary:  Send button should be disabled until we have a recipient.

Steps to Reproduce:

1.  Launch mozilla.exe -compose or just do a CTRL+M to bring up the compose window.

Expected Results:

Until you have a recipient, the Send button should be disabled. 

Actual Results:

The Send button is enabled, and of course gives an error, "Sending of message
failed: No recipients were specified...", etc. etc.

Logic:  In commercial builds were the Spell button exists on this toolbar, we
disable that button until we have text to check in the body.  Strange that
Outlook Express 6 and Netscape Messenger 4.x both have this button also enabled,
and both give the same expected error.

It's seemingly such an obvious bug.  Is there any reason it should be enabled
until we have a recipient?  I can't think of any.

Comment 1

[Jean-Francois Ducarroz]

-->varada

Comment 2

[Sheela Ravindran]

still exists->2001-12-14-06

Comment 3

[Gregg Meehan]

changing QA contact from Sheela to Gregg

Comment 4

[(not reading, please use [e-mail] instead)]

taking all of varada's bugs.

Comment 5

[:aceman]

I am not sure there is any composition code in mailnews where this can be done. This should be moved to Seamonkey.
Thunderbird bug is bug 431217.

Comment 6

[Ian Neal]

Port relevant changes from:

• Bug 431217 - Send button should be disabled until we have a recipient
• Bug 863231 - Enable Send button properly when filling recipients via Contacts sidebar
• Bug 933101 - Properly enable Send button if recipients are drag'n'dropped into the address widget or filled in by switching identities
• Bug 1290733 - Speed up UpdateSendLock() in compose window by only looking for one valid recipient
• Bug 1296535 - Enable Send button when recipient is a mailinglist
• Bug 1362130 - enable Send button when mailinglist name gets quoted

Comment 7

[Ian Neal]

Attachment: 104973-compose-sendlock-2539.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: send button always active
Testing completed (on m-c, etc.): 2.53.9
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 8

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9223129 [details] [diff] [review]
104973-compose-sendlock-2539.patch

LGTM

Bug 1701313 added a new simple newsgroup name validation in case we want this later. Send was enabled correctly during my tests so I hope mentioned bugs in this tB bug are because of the pillified address lines only.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/13f3e211a627
Port |Bug 431217 - Send button should be disabled until we have a recipient| to SeaMonkey. r=frg

Comment 10

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/4a32403e206f6ed255a31ec09ea1b28aeca5f404
Port |Bug 431217 - Send button should be disabled until we have a recipient| to SeaMonkey. r=frg a=frg