Closed Bug 1050033 Opened 7 years ago Closed 7 years ago

Eliminate BrowserDB interface

Categories

(Firefox for Android Graveyard :: Data Providers, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file)

It hasn't been necessary since we stopped supporting Android databases, and it's starting to get in the way.
Blocks: 1050034
This patch:

* Pushes RobocopTarget annotations down to LocalBrowserDB.
* Eliminates @Override annotations.
* Removes the interface.
* Makes the static members of BrowserDB volatile, because there are no controls over how they're accessed.
* Eliminates static passthrough methods of BrowserDB that aren't called by tests or the app.

Pretty small patch, considering!

I'll push this to Try later.
Attachment #8468961 - Flags: review?(lucasr.at.mozilla)
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Attachment #8468961 - Flags: feedback?(chriskitching)
Comment on attachment 8468961 [details] [diff] [review]
Eliminate BrowserDB interface. v1

Review of attachment 8468961 [details] [diff] [review]:
-----------------------------------------------------------------

Go.
Attachment #8468961 - Flags: review?(lucasr.at.mozilla) → review+
Attachment #8468961 - Flags: feedback?(chriskitching)
https://hg.mozilla.org/mozilla-central/rev/273d6c900fb1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.