1050033 - Eliminate BrowserDB interface

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Data Providers, defect)

Description

[Richard Newman [:rnewman]]

It hasn't been necessary since we stopped supporting Android databases, and it's starting to get in the way.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Eliminate BrowserDB interface. v1

This patch:

* Pushes RobocopTarget annotations down to LocalBrowserDB.
* Eliminates @Override annotations.
* Removes the interface.
* Makes the static members of BrowserDB volatile, because there are no controls over how they're accessed.
* Eliminates static passthrough methods of BrowserDB that aren't called by tests or the app.

Pretty small patch, considering!

I'll push this to Try later.

Comment 2

[Richard Newman [:rnewman]]

https://tbpl.mozilla.org/?tree=Try&rev=9a737d8dab0b

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8468961 [details] [diff] [review]
Eliminate BrowserDB interface. v1

Review of attachment 8468961 [details] [diff] [review]:
-----------------------------------------------------------------

Go.

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/273d6c900fb1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/273d6c900fb1