1050034 - Eliminate BrowserDB.URLColumns

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Data Providers, defect)

Description

[Richard Newman [:rnewman]]

As Lucas notes in Bug 723623:

"The Android backend has already been removed. What I think we should still do anyway is to get rid of BrowserDB.URLColumns and simply use BrowserContract interfaces directly. 

BrowserDB.URLColumns was only necessary while we supported the Android's system bookmarks database."

Comment 1

[Lucas Rocha (:lucasr)]

Long overdue! Please make it happen :-)

Comment 2

[Richard Newman [:rnewman]]

Attachment: Eliminate BrowserDB.URLColumns. v1

About to run tests.

Comment 3

[Richard Newman [:rnewman]]

https://tbpl.mozilla.org/?tree=Try&rev=c951550f91e3

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 8469542 [details] [diff] [review]
Eliminate BrowserDB.URLColumns. v1

This looks good on Try.

I allowed Eclipse to clean up imports as I went, which is why this patch is a little larger than you'd expect!

Comment 5

[Lucas Rocha (:lucasr)]

Comment on attachment 8469542 [details] [diff] [review]
Eliminate BrowserDB.URLColumns. v1

Review of attachment 8469542 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good but let's get rid of the cursor wrappers too.

::: mobile/android/base/db/LocalBrowserDB.java
@@ -1481,5 @@
>              return "";
>          }
>      }
>  
>      private static class LocalDBCursor extends CursorWrapper {

You should be able to remove the wrapper class as well. It was only necessary to translate from BrowserDB.URLColumns to LocalDBCursor and a AndroidDBCursor that we used to have.

Comment 6

[Richard Newman [:rnewman]]

Attachment: Eliminate BrowserDB.URLColumns. v2

Now with fewer wrappers!

Comment 7

[Lucas Rocha (:lucasr)]

Comment on attachment 8470259 [details] [diff] [review]
Eliminate BrowserDB.URLColumns. v2

Review of attachment 8470259 [details] [diff] [review]:
-----------------------------------------------------------------

Great.

Comment 8

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/b54b6d112c35

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b54b6d112c35