Closed Bug 1050034 Opened 8 years ago Closed 8 years ago

Eliminate BrowserDB.URLColumns

Categories

(Firefox for Android Graveyard :: Data Providers, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file, 1 obsolete file)

As Lucas notes in Bug 723623:

"The Android backend has already been removed. What I think we should still do anyway is to get rid of BrowserDB.URLColumns and simply use BrowserContract interfaces directly. 

BrowserDB.URLColumns was only necessary while we supported the Android's system bookmarks database."
Long overdue! Please make it happen :-)
About to run tests.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Comment on attachment 8469542 [details] [diff] [review]
Eliminate BrowserDB.URLColumns. v1

This looks good on Try.

I allowed Eclipse to clean up imports as I went, which is why this patch is a little larger than you'd expect!
Attachment #8469542 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 8469542 [details] [diff] [review]
Eliminate BrowserDB.URLColumns. v1

Review of attachment 8469542 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good but let's get rid of the cursor wrappers too.

::: mobile/android/base/db/LocalBrowserDB.java
@@ -1481,5 @@
>              return "";
>          }
>      }
>  
>      private static class LocalDBCursor extends CursorWrapper {

You should be able to remove the wrapper class as well. It was only necessary to translate from BrowserDB.URLColumns to LocalDBCursor and a AndroidDBCursor that we used to have.
Attachment #8469542 - Flags: review?(lucasr.at.mozilla) → feedback+
Now with fewer wrappers!
Attachment #8470259 - Flags: review?(lucasr.at.mozilla)
Attachment #8469542 - Attachment is obsolete: true
Comment on attachment 8470259 [details] [diff] [review]
Eliminate BrowserDB.URLColumns. v2

Review of attachment 8470259 [details] [diff] [review]:
-----------------------------------------------------------------

Great.
Attachment #8470259 - Flags: review?(lucasr.at.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/b54b6d112c35
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.