1050078 - the information about the build should have a verbal description of its status

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When you click on a build/test in treeherder, it shows a box in the lower left (as it does in TBPL).

However, this box doesn't, anywhere, contain the word "pending" or "running" or similar to describe the status.

This should be present for two reasons:

 (1) it avoids having people make distinctions based on color alone, which is extremely poor for accessibility

 (2) it provides a better way for people to learn the UI by exploring, which is often a better way to learn than a help page

In TBPL's build data box, it's one of the things shown most prominently, in the top row.

Comment 1

[Jonathan French (:jfrench)]

Makes sense to me also from a UI standpoint. The UI is already there in Treeherder at the top of that lower left panel and displaying correctly for:

Result: success
Result: busted
Result: testfailed
Result: retry

And we'd just want to add:

Result: pending
Result: running

...for suitable jobs, which presently just show as:

Result: unknown

Comment 2

[Jonathan French (:jfrench)]

And that job.result property is specified for the panel here
https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/plugins/pluginpanel.html#L131

Comment 3

[Jonathan French (:jfrench)]

Attachment: jobResultStatus_aug11_14_rev1

So (apologies.. newbie here..) in the job artifact, it appears we have job.result and job.state. They both seem correct in a pending and running job (ie. result is 'unknown'), and both legitimate pieces of information which inform each other. What do you think about including both in that current line for all jobs? I screen grabbed several results, attached. We could tune the padding on that line for more white space if desired.

Comment 4

[Jonathan French (:jfrench)]

I spoke with jeads on IRC; he's in agreement so will open a PR based on the above concept shortly.

Comment 5

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#125

I've opened a PR per above comments. Please see the PR for review and status.

Comment 6

[Ed Morley [:emorley]]

This looks good :-)

The only thing I'd change (and happy to do this as a followup if needs be) is to display something other than "unknown" for the result of pending/running. eg "-", "N/A", "TBC" etc. I guess this also applies to the other fields that we don't yet know, eg machine "unknown" -> "unallocated" / "not allocated".

Comment 7

[Jonathan French (:jfrench)]

Ok, sounds good, let's do that as a follow up bug. 'unknown' comes straight from the job artifact, so I assume we would want it modified there, rather than converting it in the platform.

Comment 8

[Ed Morley [:emorley]]

Yeah :-)

Comment 9

[Jonathan French (:jfrench)]

Above now entered as bug 1052501.

Comment 10

[Jonathan French (:jfrench)]

Merged and fixed in
https://github.com/mozilla/treeherder-ui/commit/2df99999e5d9ccdc64537ca79deaa7756ed42fd7#diff-d41d8cd98f00b204e9800998ecf8427e

I will marked resolved once it's pushed to dev/stage, and I've had a chance to check it live.

Comment 11

[Jonathan French (:jfrench)]

This has been pushed to stage and everything appears to be working as desired, so marking fixed. The new dark grey background color in the details pane for 'running' jobs could perhaps still be a tiny bit darker - but then the black text inside begins to lose readability. If we still want it a bit darker we can always try that later.