Closed Bug 1050086 Opened 5 years ago Closed 5 years ago

C-c needs a "port" of bug 1047267

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(thunderbird34 fixed)

RESOLVED FIXED
Thunderbird 34.0
Tracking Status
thunderbird34 --- fixed

People

(Reporter: glandium, Assigned: iann_bugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attached patch Port EXTRA_LIBS changes (obsolete) — Splinter Review
For some reason I had an extra 'nspr' USE_LIBS to mailnews/base/test/moz.build
I have preserved whether nspr is in or out of MOZ_INCOMPLETE_EXTERNAL_LINKAGE with the transition.
Assignee: ewong → iann_bugzilla
Attachment #8469716 - Flags: review?(Pidgeot18)
Version: unspecified → Trunk
Comment on attachment 8469716 [details] [diff] [review]
Port EXTRA_LIBS changes

Review of attachment 8469716 [details] [diff] [review]:
-----------------------------------------------------------------

::: ldap/xpcom/src/Makefile.in
@@ +17,5 @@
>  ifdef MOZ_PREF_EXTENSIONS
>  DEFINES += -DMOZ_PREF_EXTENSIONS
>  endif
>  
>  EXTRA_LIBS += $(LDAP_LIBS)

You need to address this too.
(In reply to Mike Hommey [:glandium] from comment #2)
> Comment on attachment 8469716 [details] [diff] [review]
> Port EXTRA_LIBS changes
> 
> Review of attachment 8469716 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: ldap/xpcom/src/Makefile.in
> @@ +17,5 @@
> >  ifdef MOZ_PREF_EXTENSIONS
> >  DEFINES += -DMOZ_PREF_EXTENSIONS
> >  endif
> >  
> >  EXTRA_LIBS += $(LDAP_LIBS)
> 
> You need to address this too.

So it looks offhand like ldap/Makefile.in + ldap/moz.build serve the same role as config/external/*. Copying and tweaking config/external/nsprpub for LDAP should suffice.
Comment on attachment 8469716 [details] [diff] [review]
Port EXTRA_LIBS changes

Review of attachment 8469716 [details] [diff] [review]:
-----------------------------------------------------------------

I think I'd like to see the LDAP situation resolved before checking this in.
Attachment #8469716 - Flags: review?(Pidgeot18) → feedback+
Would anyone mind if I push the im/ only parts (r=me) as a separate commit? It's the only thing still busted for Windows/Linux Instantbird. Thanks!
Joshua, how do you feel about comment 5?
Flags: needinfo?(Pidgeot18)
Fine with me.
Flags: needinfo?(Pidgeot18)
Tested locally for linux
Run on try:
Green for Windows https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=d7bc15e0c081
Waiting for OS X https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=03d011cd592b
Attachment #8469716 - Attachment is obsolete: true
Attachment #8472007 - Flags: review?(Pidgeot18)
(In reply to Ian Neal from comment #9)
> Waiting for OS X
> https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=03d011cd592b
Failed due to infra fail, will have to re-try once the infra is available again.
Another push to try for OS X
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=646f50dbe049
Comment on attachment 8472007 [details] [diff] [review]
Port EXTRA_LIBS changes and do LDAP too [Checked in: Comment 15]

You can remove MOZ_APP_COMPONENT_MODULES too.
And you can file a bug to have MOZ_APP_COMPONENT_MODULES and MOZ_APP_EXTRA_LIBS removed from m-c.
Comment on attachment 8472007 [details] [diff] [review]
Port EXTRA_LIBS changes and do LDAP too [Checked in: Comment 15]

Review of attachment 8472007 [details] [diff] [review]:
-----------------------------------------------------------------

You can kill the MOZ_APP_COMPONENT_MODULES stuff, but that's best left to a follow up, I think.

::: ldap/moz.build
@@ +19,5 @@
> +    USE_LIBS += [
> +        '/ldap/sdks/c-sdk/ldap/libraries/libldap/ldap60',
> +        '/ldap/sdks/c-sdk/ldap/libraries/libldif/ldif60',
> +        '/ldap/sdks/c-sdk/ldap/libraries/libprldap/prldap60',
> +    ]

Adding USE_LIBS += ['nspr'] may be useful.

::: mailnews/imap/test/Makefile.in
@@ -12,5 @@
>  include $(DEPTH)/config/autoconf.mk
>  
>  include $(topsrcdir)/config/rules.mk
> -
> -EXTRA_LIBS += $(NSPR_LIBS)

Delete this makefile too, please.
Attachment #8472007 - Flags: review?(Pidgeot18) → review+
Blocks: 1053439
Blocks: 1053444
Comment on attachment 8472007 [details] [diff] [review]
Port EXTRA_LIBS changes and do LDAP too [Checked in: Comment 15]

http://hg.mozilla.org/comm-central/rev/7ad2fba944f1
Attachment #8472007 - Attachment description: Port EXTRA_LIBS changes and do LDAP too → Port EXTRA_LIBS changes and do LDAP too [Checked in: Comment 15]
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0
You need to log in before you can comment on or make changes to this bug.