Closed
Bug 1053439
Opened 11 years ago
Closed 11 years ago
MOZ_APP_COMPONENT_MODULES and MOZ_APP_EXTRA_LIBS are no longer required
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(1 file)
1.72 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Once the fix to bug 1050086 lands on comm-central there is no need for MOZ_APP_COMPONENT_MODULES and MOZ_APP_EXTRA_LIBS in mozilla-central
Attachment #8472590 -
Flags: review?(mh+mozilla)
Comment 1•11 years ago
|
||
Comment on attachment 8472590 [details] [diff] [review]
Remove MOZ_APP_COMPONENT_MODULES and MOZ_APP_EXTRA_LIBS [Checked in m-i: Comment 2]
Review of attachment 8472590 [details] [diff] [review]:
-----------------------------------------------------------------
::: configure.in
@@ -8320,5 @@
> fi
>
> if test "$MOZ_APP_COMPONENT_INCLUDE"; then
> AC_DEFINE_UNQUOTED(MOZ_APP_COMPONENT_INCLUDE, "$MOZ_APP_COMPONENT_INCLUDE")
> fi
Can you remove this too in a followup?
Attachment #8472590 -
Flags: review?(mh+mozilla) → review+
Comment on attachment 8472590 [details] [diff] [review]
Remove MOZ_APP_COMPONENT_MODULES and MOZ_APP_EXTRA_LIBS [Checked in m-i: Comment 2]
https://hg.mozilla.org/integration/mozilla-inbound/rev/53e5b89085a4
Attachment #8472590 -
Attachment description: Remove MOZ_APP_COMPONENT_MODULES and MOZ_APP_EXTRA_LIBS → Remove MOZ_APP_COMPONENT_MODULES and MOZ_APP_EXTRA_LIBS [Checked in m-i: Comment 2]
Attachment #8472590 -
Flags: checkin+
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Updated•11 years ago
|
QA Whiteboard: [qa-]
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•