1050121 - package-manifest:50: Missing file(s): bin/icudtd52.dll

Status: RESOLVED DUPLICATE of bug 1022702

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

This is from a comm-beta Win build:

e:/builds/slave/c-beta-w32-dbg/build/objdir/mozilla/_virtualenv/Scripts/python.exe e:/builds/slave/c-beta-w32-dbg/build/mozilla/toolkit/mozapps/installer/packager.py -DOSTYPE=\"WINNT5.2\" -DOSARCH=WINNT -DNO_NSPR_10_SUPPORT -DAB_CD=en-US -DMOZ_APP_NAME=seamonkey -DPREF_DIR=defaults/pref -DJAREXT= -DENABLE_TESTS=1 -DMOZ_ANGLE_RENDERER=1 -DMOZ_D3DCOMPILER_XP_DLL=D3DCompiler_43.dll -DMOZ_DEBUG=1 -D_MSC_VER=1600 -DMOZ_URL_CLASSIFIER=1 -DMOZ_UPDATER=1 -DNECKO_WIFI=1 -DMOZ_MSVC_REDIST=1600 -DMOZ_SHARED_MOZGLUE=1 -DMOZ_CHILD_PROCESS_NAME=plugin-container.exe -DDLL_PREFIX= -DDLL_SUFFIX=.dll -DBIN_SUFFIX=.exe -DMOZ_FOLD_LIBS=1 -DBINPATH=bin -DMOZ_ICU_VERSION=52 -DMOZ_SHARED_ICU \
	--format omni \
	--removals e:/builds/slave/c-beta-w32-dbg/build/suite/installer/removed-files.in \
	 \
	 \
	 \
	 \
	--optimizejars \
	 \
	package-manifest ../../mozilla/dist ../../mozilla/dist/seamonkey \
	--non-resource defaults/messenger/mailViews.dat defaults/profile/localstore.rdf defaults/profile/panels.rdf 
Error: e:\builds\slave\c-beta-w32-dbg\build\objdir\suite\installer\package-manifest:50: Missing file(s): bin/icudtd52.dll
Error: e:\builds\slave\c-beta-w32-dbg\build\objdir\suite\installer\package-manifest:51: Missing file(s): bin/icuind52.dll
Error: e:\builds\slave\c-beta-w32-dbg\build\objdir\suite\installer\package-manifest:52: Missing file(s): bin/icuucd52.dll
Traceback (most recent call last):
  File "e:/builds/slave/c-beta-w32-dbg/build/mozilla/toolkit/mozapps/installer/packager.py", line 402, in <module>
    main()
  File "e:/builds/slave/c-beta-w32-dbg/build/mozilla/toolkit/mozapps/installer/packager.py", line 354, in main
    copier.add(mozpack.path.join(binpath, 'removed-files'), removals)
  File "d:\mozilla-build\python27\Lib\contextlib.py", line 24, in __exit__
    self.gen.next()
  File "e:\builds\slave\c-beta-w32-dbg\build\mozilla\python\mozbuild\mozpack\errors.py", line 129, in accumulate
    raise AccumulatedErrors()
mozpack.errors.AccumulatedErrors

Comment 1

[Edmund Wong (:ewong)]

Attachment: bustage fix patch (v1)

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: windows debug beta build busted
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 2

[Edmund Wong (:ewong)]

Comment on attachment 8469094 [details] [diff] [review]
bustage fix patch (v1)

This is for a post-push review.

Comment 3

[Edmund Wong (:ewong)]

Attachment: bustage fix patch (v2)

Comment 4

[Edmund Wong (:ewong)]

Comment on attachment 8469099 [details] [diff] [review]
bustage fix patch (v2)

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: windows debug build busted
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 5

[Edmund Wong (:ewong)]

Attachment: patch (V3)

Comment 6

[Edmund Wong (:ewong)]

Comment on attachment 8469102 [details] [diff] [review]
patch (V3)

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 7

[Edmund Wong (:ewong)]

Comment on attachment 8469102 [details] [diff] [review]
patch (V3)

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: windows debug build bustage.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 8

[Edmund Wong (:ewong)]

Closing this bug.  This is a fallout of not uplifting the patch for
bug 1022702.