1050456 - Kill pages that reach the maximum script execution timeout in prerendering mode

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

The reasoning is that we cannot show the dialog to the user.

Comment 1

[(no longer active)]

Attachment: Prevent prerendered pages from showing the slow script dialog

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8572207 [details] [diff] [review]
Prevent prerendered pages from showing the slow script dialog

>+    // This doesn't work yet.  We manage to get the source of the script somehow.
>+    // TODO investigate if we can get to the page running the script from there...

What's with these comments?

>+    if (docShell && docShell->GetIsPrerendered()) {

Might be nice to have a getter for prerendering state on the window so we don't have to do the docshell dance here....

r=me either way, as long as those comments are fixed to either reflect reality or explain what they're talking about.

Comment 3

[(no longer active)]

(In reply to Not doing reviews right now from comment #2)
> Comment on attachment 8572207 [details] [diff] [review]
> Prevent prerendered pages from showing the slow script dialog
> 
> >+    // This doesn't work yet.  We manage to get the source of the script somehow.
> >+    // TODO investigate if we can get to the page running the script from there...
> 
> What's with these comments?

Oops, sorry I was investigating issues with the test, these are my todo comments.

> >+    if (docShell && docShell->GetIsPrerendered()) {
> 
> Might be nice to have a getter for prerendering state on the window so we
> don't have to do the docshell dance here....

Done:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d9f869afa7c
https://hg.mozilla.org/integration/mozilla-inbound/rev/52b5566554b0

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3d9f869afa7c
https://hg.mozilla.org/mozilla-central/rev/52b5566554b0