Closed Bug 1050457 Opened 6 years ago Closed 6 years ago

Search activity edit field has border on Android 4.1

Categories

(Firefox for Android Graveyard :: Search Activity, defect, P1)

34 Branch
ARM
Android
defect

Tracking

(firefox35 verified)

VERIFIED FIXED
Firefox 35
Tracking Status
firefox35 --- verified

People

(Reporter: aaronmt, Assigned: Margaret)

References

Details

(Whiteboard: shovel-ready)

Attachments

(3 files)

Attached image screenshot.png
See screenshot

--
Nightly (08/07)
Samsung Galaxy SII (Android 4.1.2)
The real bug there is that there's a border at all. There should only be a border on the bottom.

Aaron, do you know the screen density of the device you were testing? Is that border always there?
Summary: Search activity magnifying glass/edit field close button overlap with border on Android 4.1 → Search activity edit field has border on Android 4.1
Priority: -- → P1
(In reply to :Margaret Leibovic from comment #1)
> The real bug there is that there's a border at all. There should only be a
> border on the bottom.
> 
> Aaron, do you know the screen density of the device you were testing? Is
> that border always there?

Galaxy SII is high-density (hdpi)/normal screen size, yes that border is always there
Assignee: nobody → margaret.leibovic
I noticed that there is also a problem with the border on my Nexus S (2.3.6).

Fixing this will involve tweaking the edit_text_background drawable:
https://github.com/mozilla/fennec-search/blob/master/app/src/main/res/drawable/edit_text_background.xml
Assignee: margaret.leibovic → nobody
Whiteboard: shovel-ready
Duplicate of this bug: 1059463
This will probably be fixed by my patch in bug 1049600.
This should be fixed by the patch in bug 1049600. The issue was resolved for me where I was experiencing it (Nexus S).

Aaron, can you try this again when bug 1049600 hits Nightly?
Depends on: 1049600
Flags: needinfo?(aaron.train)
Assignee: nobody → margaret.leibovic
Attached image screenshot.png
This is still seen on trunk Nightly (09/23).

What it looks like now
Flags: needinfo?(aaron.train)
Not gonna lie, I don't totally understand why this was happening (and only on some devices). It seems like it's some screen resolution problem, but expanding the edges of the rectangle we use to hide the top/right/left border by 1dp appears to fix the problem, without causing regressions on other devices.
Attachment #8494867 - Flags: review?(liuche)
Attachment #8494867 - Flags: review?(liuche) → review+
https://hg.mozilla.org/mozilla-central/rev/dab8d3c1e8c9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Verified as fixed in build 35.0a1 (2014-10-02);
Device Samsung Galaxy S2 (Android 4.1.2);
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.