1050457 - Search activity edit field has border on Android 4.1

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect, P1)

Description

[Aaron Train [:aaronmt]]

Attachment: screenshot.png

See screenshot

--
Nightly (08/07)
Samsung Galaxy SII (Android 4.1.2)

Comment 1

[:Margaret Leibovic]

The real bug there is that there's a border at all. There should only be a border on the bottom.

Aaron, do you know the screen density of the device you were testing? Is that border always there?

Comment 2

[Aaron Train [:aaronmt]]

(In reply to :Margaret Leibovic from comment #1)
> The real bug there is that there's a border at all. There should only be a
> border on the bottom.
> 
> Aaron, do you know the screen density of the device you were testing? Is
> that border always there?

Galaxy SII is high-density (hdpi)/normal screen size, yes that border is always there

Comment 3

[:Margaret Leibovic]

I noticed that there is also a problem with the border on my Nexus S (2.3.6).

Fixing this will involve tweaking the edit_text_background drawable:
https://github.com/mozilla/fennec-search/blob/master/app/src/main/res/drawable/edit_text_background.xml

Comment 5

[:Margaret Leibovic]

This will probably be fixed by my patch in bug 1049600.

Comment 6

[:Margaret Leibovic]

This should be fixed by the patch in bug 1049600. The issue was resolved for me where I was experiencing it (Nexus S).

Aaron, can you try this again when bug 1049600 hits Nightly?

Comment 7

[Aaron Train [:aaronmt]]

Attachment: screenshot.png

This is still seen on trunk Nightly (09/23).

What it looks like now

Comment 8

[:Margaret Leibovic]

Attachment: ncrease top/right/left alues of edit_text_focus layer-list drawable to fix pixel issue on 4.1

Not gonna lie, I don't totally understand why this was happening (and only on some devices). It seems like it's some screen resolution problem, but expanding the edges of the rectangle we use to hide the top/right/left border by 1dp appears to fix the problem, without causing regressions on other devices.

Comment 9

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/dab8d3c1e8c9

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dab8d3c1e8c9

Comment 11

[Flaviu Cos]

Verified as fixed in build 35.0a1 (2014-10-02);
Device Samsung Galaxy S2 (Android 4.1.2);