1050481 - Add match whole words option to Find-in-page

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Desktop has this now. We should add support. I think this will depend on having a menu of some sort. That will be handled automatically by the actionmode in bug 1050479 eventually, so I think this will depend on that bug.

Comment 1

[Mark Capella [:capella]]

I don't actually see a (match-word) option on desktop ... is this conflated with completed bug 1050480 (match-case) ?

Comment 2

[Richard Newman [:rnewman]]

No, I think Wes just copy-and-pasted the description from Bug 1050480.

This is parity with more sophisticated systems than desktop. Arguably it's even more necessary on mobile, where seeing more matches on the page is much harder, so a more precise search is valuable.

Comment 3

[Mark Capella [:capella]]

mmm ... I might need to tune in a little closer to Bug 1050479 - Make find-in-page an action mode then ... I suppose this bug is to add the match-word option to the newer actionbar design than to add it to the native FindInPageBar (?) which I think will be replaced (??)

Or is the thought to squeeze another toggle/CheckedTextView to find_in_page_content.xml ?

Comment 4

[Richard Newman [:rnewman]]

The former.

We just turned off the match-case toggle (Bug 1113296) because it wasn't an experience we want to ship yet. 

Providing a better experience probably depends on an action mode, and that issue generalizes to this bug, too, which is why Wes marked this as depending on Bug 1050479.

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.