105057 - images used as form controls doesn't appear on Page Info | Images

Status: VERIFIED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Adam Hauner]

Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9.5+) Gecko/20011014-trunk

Repro (Always):
1. open an attachment in new windows
2. you see two pictures - a form button 'JDI' and small black square
3. go to Page Info (Ctrl+I)
4. go to 'Images' tab

Actual:
You will see only black square image listed (../bt.gif), form button isn't there
(http://j.lupa.cz/m/g/tl-jdi.gif)

Wanted:
All pictures used in page are diplayed.

If this bug will be confirmed, add please bug 82059 to BugsDependsOnThis.

Comment 1

[Adam Hauner]

Attachment: testcase

Comment 2

[James McCoy]

seeing this with 2001101513/Redhat 7.1

Comment 3

[sairuh (rarely reading bugmail)]

->daniel

Comment 4

[sairuh (rarely reading bugmail)]

mass moving open bugs pertaining to page info to [e-mail] as qa contact.

to find all bugspam pertaining to this, set your search string to
"BigBlueDestinyIsHere".

Comment 5

[Daniel Brooks [:db48x]]

*** Bug 121629 has been marked as a duplicate of this bug. ***

Comment 6

[Boris Zbarsky [:bzbarsky]]

confirmed.

The problem is that grabAllMedia grabs <input type="image"> but the

switch (elem.nodeName.toLowerCase())

in makeMediaTab() does not have a case for "input".  Add the "image input" type
to the media type list?  Or just make "img" and "input" do the same thing?

makePreview() may need updating too... Does the src of <input type="image">
return a relative or absolute URL?

Comment 7

[Daniel Brooks [:db48x]]

I'll do some debugging on this tonight, should be simple and I'll have a patch
in morning.

Comment 8

[Daniel Brooks [:db48x]]

oh, bz, thanks. you beat me to it, I'd gone off for some ice cream :)

That does look like the reason. I'll test some changes now, but I won't be able
to make a patch until tommorrow

Comment 9

[Daniel Brooks [:db48x]]

bleh, the dom sucks. I've got it working, but it has the same problem that
images specified in link tabs have, they don't show up in the preview pane. The
problem is that neither the input nor the link tab stores the width or height of
the image, so it ends up as a 0x0 image in the preview window. I suppose either
those properties need to be added (yes, they'd be a netscape extension, but oh
well), or the xul image tag needs to have a better setter on it's .src property
that can find the width and height, which it doesn't appear to do.

Comment 10

[Daniel Brooks [:db48x]]

Attachment: fixes input and links

thanks to bz for the idea

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 66503 [details] [diff] [review]
fixes input and links

r=bzbarsky

Comment 12

[Daniel Brooks [:db48x]]

jag, can you sr=?

Comment 13

[jag (Peter Annema)]

Comment on attachment 66503 [details] [diff] [review]
fixes input and links

>Index: xpfe/browser/resources/content/pageInfo.js
>===================================================================
>RCS file: /cvsroot/mozilla/xpfe/browser/resources/content/pageInfo.js,v
>retrieving revision 1.14
>diff -u -r1.14 pageInfo.js
>--- xpfe/browser/resources/content/pageInfo.js	2002/01/24 07:27:47	1.14
>+++ xpfe/browser/resources/content/pageInfo.js	2002/01/25 20:20:07
>@@ -672,8 +677,10 @@
>   }
> 
>   newImage.setAttribute("id", "thepreviewimage");
>-  newImage.width = ("width" in item && item.width) || unknown;
>-  newImage.height = ("height" in item && item.height) || unknown;
>+  if ("width" in item && item.width)
>+    newImage.width = item.width;
>+  if ("height" in item && item.height)
>+      newImage.height = item.height;

Nit: indent

Fix that and sr=jag

Comment 14

[Daniel Brooks [:db48x]]

Attachment: fix nit :P

Comment 15

[jag (Peter Annema)]

Comment on attachment 66560 [details] [diff] [review]
fix nit :P

transferring r= and sr=.

No need to attach new patches for such nits, generally.

Comment 16

[Daniel Brooks [:db48x]]

yea, I just can't check it in, so I figured I'd save someone the trouble while I
was working on other bugs :)

Comment 17

[Daniel Brooks [:db48x]]

thanks timeless, marking fixed

Comment 18

[Matthias Versen [:Matti]]

verified fixed with an 5min old CVS build

Comment 19

[Boris Zbarsky [:bzbarsky]]

*** Bug 122207 has been marked as a duplicate of this bug. ***