Closed Bug 1050597 Opened 6 years ago Closed 6 years ago

Remove leaktests from SeaMonkey buildbotconfigs/custom code.

Categories

(SeaMonkey :: Release Engineering, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ewong, Assigned: ewong)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1013680 removed _leaktest from the objdir, which explains why SeaMonkey's
debug Alive tests were choking with the following:

python: can't open file 'leaktest.py': [Errno 2] No such file or directory

neither _leaktest, nor leaktest.py are generated anymore.

And iirc, before our infra problems, Callek did mention that the Alive
tests were not useful.  (I'm wondering if I can generalize that to the
whole leaktest part)

Now if this is true, then the code needs to go as it's blocking debug builds
on c-b (et.al).
Callek, so is comment #0 right?  and if so, do I get a patch up for this bug,
and once r+, I push this patch to buildbotcustom and buildbot-config,
and then update my bug 840427 patches accordingly? or should I just 
do that in one fell swoop in bug 840427?
Flags: needinfo?(bugspam.Callek)
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attached patch bug_1050597.diff (obsolete) — Splinter Review
on precursory scan, I don't think there are any config changes that need
to be done.
Attachment #8469745 - Flags: review?(bugspam.Callek)
Comment on attachment 8469745 [details] [diff] [review]
bug_1050597.diff

Review of attachment 8469745 [details] [diff] [review]:
-----------------------------------------------------------------

r- JUST for the one issue below, the REST of this patch is indeed correct and wanted.

::: process/factory.py
@@ -61,5 @@
>  from buildbotcustom.steps.release import UpdateVerify, L10nVerifyMetaDiff, \
>    SnippetComparison
>  from buildbotcustom.steps.source import MercurialCloneCommand
> -from buildbotcustom.steps.test import AliveTest, \
> -  CompareLeakLogs, GraphServerPost

need to keep "GraphServerPost" here
Attachment #8469745 - Flags: review?(bugspam.Callek) → review-
Flags: needinfo?(bugspam.Callek)
Attached patch patch (v2)Splinter Review
Attachment #8469745 - Attachment is obsolete: true
Attachment #8474979 - Flags: review?(bugspam.Callek)
Attachment #8474979 - Flags: review?(bugspam.Callek) → review+
Blocks: 1072713
I believe this is fixed.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.