1050597 - Remove leaktests from SeaMonkey buildbotconfigs/custom code.

Status: RESOLVED FIXED

(SeaMonkey :: Release Engineering, defect)

Description

[Edmund Wong (:ewong)]

Bug 1013680 removed _leaktest from the objdir, which explains why SeaMonkey's
debug Alive tests were choking with the following:

python: can't open file 'leaktest.py': [Errno 2] No such file or directory

neither _leaktest, nor leaktest.py are generated anymore.

And iirc, before our infra problems, Callek did mention that the Alive
tests were not useful.  (I'm wondering if I can generalize that to the
whole leaktest part)

Now if this is true, then the code needs to go as it's blocking debug builds
on c-b (et.al).

Comment 1

[Edmund Wong (:ewong)]

Callek, so is comment #0 right?  and if so, do I get a patch up for this bug,
and once r+, I push this patch to buildbotcustom and buildbot-config,
and then update my bug 840427 patches accordingly? or should I just 
do that in one fell swoop in bug 840427?

Comment 2

[Edmund Wong (:ewong)]

Attachment: bug_1050597.diff

on precursory scan, I don't think there are any config changes that need
to be done.

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 8469745 [details] [diff] [review]
bug_1050597.diff

Review of attachment 8469745 [details] [diff] [review]:
-----------------------------------------------------------------

r- JUST for the one issue below, the REST of this patch is indeed correct and wanted.

::: process/factory.py
@@ -61,5 @@
>  from buildbotcustom.steps.release import UpdateVerify, L10nVerifyMetaDiff, \
>    SnippetComparison
>  from buildbotcustom.steps.source import MercurialCloneCommand
> -from buildbotcustom.steps.test import AliveTest, \
> -  CompareLeakLogs, GraphServerPost

need to keep "GraphServerPost" here

Comment 4

[Edmund Wong (:ewong)]

Attachment: patch (v2)

Comment 5

[Edmund Wong (:ewong)]

I believe this is fixed.