1072713 - [Tracking Bug] SeaMonkey RelEng buildbotcustom/config code changes.

Status: RESOLVED FIXED

(SeaMonkey :: Release Engineering, defect)

Description

[Edmund Wong (:ewong)]

This bug is to keep track of the plethora of SeaMonkey RelEng bugs
that have patches that I need to keep track of.

Will add the necessary dependencies next.

Comment 1

[Edmund Wong (:ewong)]

Note: Will gather all the currently manually applied patches on the master and
will put them here for review. (so that I can order them properly for review :) )

Comment 2

[Edmund Wong (:ewong)]

Attachment: [config] Bug 106425 - Remove mozilla objdir [patch 1]

Comment 3

[Edmund Wong (:ewong)]

Attachment: [config] Bug 1023644 - Changes to support Win32 tooltool [patch 2]

Comment 4

[Edmund Wong (:ewong)]

Attachment: [config] Bug 840427 - Migrate to mock (python path change) [patch 3]

Comment 5

[Edmund Wong (:ewong)]

Attachment: [config] Bug 1066412 - Fix for Win32 tooltool_script var change [patch 4]

Comment 6

[Edmund Wong (:ewong)]

Attachment: [custom] bug 840427 - buildbotcustom code changes to support mock (bug fixes) [patch 1] [checked-in]

Comment 7

[Edmund Wong (:ewong)]

Attachment: [custom] Bug 1059072 - Custom code changes to support partials with beta 2. [patch 2] [checked-in]

Comment 8

[Edmund Wong (:ewong)]

Attachment: [custom] Bug 1064265 - custom code changes to remove objdir [patch 3] [checked-in]

Comment 9

[Edmund Wong (:ewong)]

Attachment: [custom] bug 1023644 - custom code changes to support Win32 tooltool [patch 4] [checked-in]

Comment 10

[Edmund Wong (:ewong)]

Attachment: [custom] Bug 1064265 - Specify mozilladir, mozillaSrcDir [patch 5] [checked-in]

Comment 11

[Edmund Wong (:ewong)]

Attachment: [custom] Bug 1072088 - Custom code fix to run tooltool step. [ patch 6] [checked-in]

Comment 12

[Edmund Wong (:ewong)]

Attachment: [custom] bug 1073327 - custom code changes to fix l10n dep repacks. [ patch 7 ] [checked-in]

Comment 13

[Edmund Wong (:ewong)]

Attachment: [custom] Bug 1023644 -workdir fix for tooltool. [patch 8] [checked-in]

Comment 14

[Edmund Wong (:ewong)]

Attachment: [config] Bug 1064265 - Remove mozilla objdir [patch 1] [checked-in]

Needed to update buildbot-configs as 2.31 has been uplifted to release.

Comment 15

[Justin Wood (:Callek)]

Comment on attachment 8516407 [details] [diff] [review]
[config] Bug 1023644 - Changes to support Win32 tooltool [patch 2]

Review of attachment 8516407 [details] [diff] [review]:
-----------------------------------------------------------------

::: seamonkey/config.py
@@ +364,4 @@
>              'enable_opt_unittests': False,
>              'enable_checktests': True,
>              'tooltool_manifest_src': 'suite/config/tooltool-manifests/win32/releng.manifest',
> +            'tooltool_script': ['python2.7', 'd:/mozilla-build/tooltool.py'],

Do you recall why we used the win-style path, as opposed to msys style path?

MoCo code makes me wonder if this is right:

http://mxr.mozilla.org/build/source/buildbot-configs/mozilla/config.py#964

Comment 16

[Edmund Wong (:ewong)]

(In reply to Justin Wood (:Callek) from comment #15)
> Comment on attachment 8516407 [details] [diff] [review]
> [config] Bug 1023644 - Changes to support Win32 tooltool [patch 2]
> 
> Review of attachment 8516407 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: seamonkey/config.py
> @@ +364,4 @@
> >              'enable_opt_unittests': False,
> >              'enable_checktests': True,
> >              'tooltool_manifest_src': 'suite/config/tooltool-manifests/win32/releng.manifest',
> > +            'tooltool_script': ['python2.7', 'd:/mozilla-build/tooltool.py'],
> 
> Do you recall why we used the win-style path, as opposed to msys style path?
> 
> MoCo code makes me wonder if this is right:
> 
> http://mxr.mozilla.org/build/source/buildbot-configs/mozilla/config.py#964

I'm not sure why we used the win-style path.  I believe I did use the msys
style path and it didn't work (though I don't remember why).  I can
change it back to the msys and see what happens. (right now, I tried
it on c-c Win32 and apparently the tooltool step's ok... but we're
naturally busted on the compile so I just retriggered an aurora build
to see (with win-style path, it's orange)).

Comment 17

[Edmund Wong (:ewong)]

Comment on attachment 8531002 [details] [diff] [review]
[config] Bug 1064265 - Remove mozilla objdir [patch 1] [checked-in]

Pushed to buildbot-configs:
  http://hg.mozilla.org/build/buildbot-configs/rev/6c7f47662e52

Comment 18

[Edmund Wong (:ewong)]

Comment on attachment 8516407 [details] [diff] [review]
[config] Bug 1023644 - Changes to support Win32 tooltool [patch 2]

Pushed to buildbot-configs:
http://hg.mozilla.org/build/buildbot-configs/rev/5b884dc76eb4

Comment 19

[Edmund Wong (:ewong)]

Comment on attachment 8516409 [details] [diff] [review]
[config] Bug 840427 - Migrate to mock (python path change) [patch 3]

Pushed to buildbot-configs:
  http://hg.mozilla.org/build/buildbot-configs/rev/a56ff11b6119

Comment 20

[Edmund Wong (:ewong)]

Comment on attachment 8516411 [details] [diff] [review]
[config] Bug 1066412 - Fix for Win32 tooltool_script  var change [patch 4]

Pushed to buildbot-configs:
http://hg.mozilla.org/build/buildbot-configs/rev/899c77d06093

Comment 21

[Edmund Wong (:ewong)]

Attachment: [custom] [Bug 1064265] (patch 5b) added mozillaDir, mozillaSrcDir to CCNightlyRepackFactory.. (v1) [checked-in]

Comment 22

[Edmund Wong (:ewong)]

Attachment: [custom] [bug 1073327] (patch 7b) repacks need proper workdir [checked-in]

Comment 23

[Edmund Wong (:ewong)]

Attachment: [custom] [Bug 1087086] - use right env for clobber step. [checked-in]

Comment 24

[Edmund Wong (:ewong)]

Attachment: [custom] [bug 1087092] - make unpack step failing: [patch 9] [checked-in]

Comment 25

[Edmund Wong (:ewong)]

Attachment: [custom] [bug 1143527] Clean up unused steps. [patch 10] [checked-in]

Comment 26

[Edmund Wong (:ewong)]

Attachment: [custom] [bug 1064265] - fix for removing mozilla objdir. [patch 3b] [checked-in]

Comment 27

[Edmund Wong (:ewong)]

Attachment: [custom] [bug 908090] - Use proper python version [patch 11] [checked-in]

Comment 28

[Edmund Wong (:ewong)]

Attachment: [custom] [bug 1180065] - Add 'export' to the make command for the make_config step. [patch 12] [checked-in]

Comment 29

[Edmund Wong (:ewong)]

Attachment: [custom] [bug 1183026] Use th right workdir and parameters for the steps in preClean. [patch 13] [checked-in]

Comment 30

[Edmund Wong (:ewong)]

Pushed to buildbotcustom:
http://hg.mozilla.org/build/buildbotcustom/rev/eadcb8075490 [patch 1]
http://hg.mozilla.org/build/buildbotcustom/rev/88b5e6a39b2a [patch 2]
http://hg.mozilla.org/build/buildbotcustom/rev/80558726ef23 [patch 3]
http://hg.mozilla.org/build/buildbotcustom/rev/eaf68c92c964 [patch 4]
http://hg.mozilla.org/build/buildbotcustom/rev/be987d38eebf [patch 5]
http://hg.mozilla.org/build/buildbotcustom/rev/4664b0e08846 [patch 6]
http://hg.mozilla.org/build/buildbotcustom/rev/64fb4e0b8b92 [patch 7]
http://hg.mozilla.org/build/buildbotcustom/rev/f9d2d74febe4 [patch 7b]
http://hg.mozilla.org/build/buildbotcustom/rev/88705d9370ad [patch 8]
http://hg.mozilla.org/build/buildbotcustom/rev/cae88039de83 [patch 9]
http://hg.mozilla.org/build/buildbotcustom/rev/4faddfb985ee [patch 10]
http://hg.mozilla.org/build/buildbotcustom/rev/38023e27a242 [patch 3b]
http://hg.mozilla.org/build/buildbotcustom/rev/1c30f61a5608 [patch 11]
http://hg.mozilla.org/build/buildbotcustom/rev/1206c32a0817 [patch 12]
http://hg.mozilla.org/build/buildbotcustom/rev/bdc82feaedbc [patch 13]

Comment 31

[Edmund Wong (:ewong)]

I've checked in all the necessary patches and on irc, Callek mentioned that he 
won't likely be able to get to the reviews so I can just drop the reviews and
close it.