1050665 - 'Null' shown in voice mail notification

Status: VERIFIED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: v2.0-flame-voicemail-notification.png

### STR
1. send a voice mail to device
2. check the notification

### Actual
'null' shown
v2.1-buri-voicemail-notification.png
v2.1-flame-voicemail-notification.png

### Expected
'One new voicemail'
v2.0-flame-voicemail-notification.png

### Version
v2.0-Flame
Gaia      8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/4bd4b0ae7bbe
BuildID   20140721000201
Version   32.0a2
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230


v2.1-Flame
Gaia      54c3c19d439f7dbafda5c6cc3b4850b545a068ba
Gecko     https://hg.mozilla.org/mozilla-central/rev/bd44d84142e8
BuildID   20140807160201
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

v2.1-Buri
Gaia      15c84c943e41ad834640a45e1e1c2ac804168af7
Gecko     https://hg.mozilla.org/mozilla-central/rev/30907d52c4c2
BuildID   20140723160203
Version   34.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

Comment 1

[Eric Chang [:ericcc] [:echang]]

Attachment: v2.1-flame-voicemail-notification.png

Comment 2

[Eric Chang [:ericcc] [:echang]]

Attachment: v2.1-buri-voicemail-notification.png

Comment 3

[Eric Chang [:ericcc] [:echang]]

hi, arthur, could you help to check this, thanks.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Alexandre might know better than me regarding voicemail notifications.

Comment 5

[:gerard-majax]

I don't have any issue on my Nexus S running master.

Comment 6

[:gerard-majax]

I got to reproduce if I leave a Voicemail on my Free Mobile SIM card and reboot. When it happens, I have a "null" string, and not a |null| value.

Comment 7

[:gerard-majax]

I see that bug 906404 did some changes to the Voicemail API in master a couple of weeks ago.

Comment 8

[:gerard-majax]

[Blocking Requested - why for this release]: regression.

Comment 9

[:gerard-majax]

After a local backout of bug 906404 (1e6a327d21a754096a12d84beede62501523d4e9), I do not reproduce the issue anymore.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Does anyone happen to know what thing is showing the null? I mean what code.

Comment 11

[:gerard-majax]

returnMessage at https://github.com/mozilla-b2g/gaia/blob/87423d44627499ba929d4cb43aed5d15ed6ac990/apps/system/js/voicemail.js#L40 is "null" instead of |null|.

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Aha, returnNumber and returnMessage should both be probably nullable.
Otherwise the internal null will be converted to "null" string.

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

Attachment: possible patch

Could anyone test this?
(I don't know how to even send voice mail)

Comment 14

[:gerard-majax]

That does fix the issue, as far as I can tell.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/56ff14a9e0f6

Comment 16

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/mozilla-central/rev/56ff14a9e0f6

Comment 18

[Gregor Wagner [:gwagner]]

Already in 2.1

Comment 19

[Eric Chang [:ericcc] [:echang]]

Gaia-Rev        b542080231bb9cdbdb282ab926965ad3f91f7460
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/d614ae398c03
Build-ID        20140923155123
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  27
FW-Date         Thu Sep  4 14:59:02 CST 2014
Bootloader      L1TC10011800