Closed Bug 1050780 Opened 5 years ago Closed 5 years ago
Browser menu missing dividers in Android L Preview
79.87 KB, image/png
1.02 MB, image/png
2.04 KB, patch
|Details | Diff | Splinter Review|
On Android L Preview (LPV81C), the in-browser menu seems to be missing a bunch of dividers for each menu item. See screenshot. -- Nexus 7 (L Preview LPV81C)
Similar to bug 963249, the dividers are missing only when the menu is opened on about:home again
Actually I retract that. Here's an example in content with the 'Page' menu missing dividers.
For the record, it seems we've had similar issues before. See bug 963249.
Let's track this to get it in ASAP, and we can look to uplift if there's a low-risk fix.
tracking-fennec: ? → 33+
Comment on attachment 8481442 [details] [diff] [review] Avoid disabled items in GeckoMenu's adapter (r=margaret) Review of attachment 8481442 [details] [diff] [review]: ----------------------------------------------------------------- I initially thought this was an Android bug but it seems this is the intended behaviour in ListView. Dividers are not drawn around items disabled in the adapter. See: https://github.com/android/platform_frameworks_base/blob/master/core/java/android/widget/ListView.java#L3274 I had to change the background selector to only show pressed state on enabled menu items as the ListView's OnItemClickListener will still set pressed state on the disabled menu item.
Attachment #8481442 - Flags: review?(margaret.leibovic)
Attachment #8481442 - Flags: review?(margaret.leibovic) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Version: Firefox 34 → Firefox 35
Comment on attachment 8481442 [details] [diff] [review] Avoid disabled items in GeckoMenu's adapter (r=margaret) Approval Request Comment [Feature/regressing bug #]: the Android L release [User impact if declined]: menu looks visually broken when certain items are disabled. [Describe test coverage new/current, TBPL]: Local testing on Kitkat/L devices only. Let's bake this in Nightly for a few days and then uplift. [Risks and why]: Low, simply avoid disabling items in the menu's adapter so that dividers are always drawn before/after them. [String/UUID change made/needed]: n/a
You need to log in before you can comment on or make changes to this bug.