Closed
Bug 963249
Opened 11 years ago
Closed 11 years ago
Regression: Menu difference on tablets between about:home and content
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox27 unaffected, firefox28 unaffected, firefox29 affected, firefox30 fixed, fennec29+)
RESOLVED
FIXED
Firefox 30
Tracking | Status | |
---|---|---|
firefox27 | --- | unaffected |
firefox28 | --- | unaffected |
firefox29 | --- | affected |
firefox30 | --- | fixed |
fennec | 29+ | --- |
People
(Reporter: aaronmt, Assigned: bnicholson)
References
Details
(Keywords: regression, reproducible, Whiteboard: [tablet])
Attachments
(3 files)
See screenshot. For whatever reason when Find in Page is disabled, we have a couple dividers removed. -- Nightly (01/23) Samsung Galaxy Tab 3 10" (x86)
Reporter | ||
Comment 1•11 years ago
|
||
Reporter | ||
Updated•11 years ago
|
Whiteboard: [tablet]
Comment 2•11 years ago
|
||
* Find in Page should be disabled for about:home * I wonder if the dividers are not drawn if the menu id disabled? Looks like the divider is drawn for Share though.
Updated•11 years ago
|
Assignee: nobody → bnicholson
tracking-fennec: ? → 29+
Assignee | ||
Comment 3•11 years ago
|
||
Can't reproduce this on the Android emulator -- have you seen this on non-x86 tablets as well?
Flags: needinfo?(aaron.train)
Keywords: regressionwindow-wanted
Reporter | ||
Comment 4•11 years ago
|
||
Yes. On my Xperia Tablet Z: bug 970365. Forgot I filed this. Duping my new one
Flags: needinfo?(aaron.train)
Reporter | ||
Comment 6•11 years ago
|
||
Sony Xperia Z Tablet screenshot: https://bugzilla.mozilla.org/attachment.cgi?id=8373393
Assignee | ||
Comment 7•11 years ago
|
||
Having a ListView item disabled hides the dividers for that item, and this appears to be the "intended behavior" [1]. The workaround, according to several sources ([2], [3], etc.) is to override areAllItemsEnabled in the adapter to always return true. I can verify that this fixes the divider issue, and the individual items are still disabled as expected. [1] https://groups.google.com/d/msg/android-developers/uoiJo0djRZ8/wb-iOy5bmawJ [2] http://stackoverflow.com/a/9197037/1524401 [3] http://java.dzone.com/articles/android-listview-%E2%80%93-fixing
Attachment #8379549 -
Flags: review?(wjohnston)
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
status-firefox30:
--- → affected
Keywords: regressionwindow-wanted
Hardware: x86 → All
Comment 8•11 years ago
|
||
Comment on attachment 8379549 [details] [diff] [review] Override MenuItemsAdapter#areAllItemsEnabled to always be true Review of attachment 8379549 [details] [diff] [review]: ----------------------------------------------------------------- :(
Attachment #8379549 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 9•11 years ago
|
||
Yeah, I don't like this fix either. When areAllItemsEnabled() returns true, individual items can still still be disabled, so what does areAllItemsEnabled() actually *do*? https://hg.mozilla.org/integration/fx-team/rev/8f547ee05df3
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8f547ee05df3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•