963249 - Regression: Menu difference on tablets between about:home and content

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: about:home screenshot

See screenshot.

For whatever reason when Find in Page is disabled, we have a couple dividers removed.

--
Nightly (01/23)
Samsung Galaxy Tab 3 10" (x86)

Comment 1

[Aaron Train [:aaronmt]]

Attachment: content screenshot

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

* Find in Page should be disabled for about:home
* I wonder if the dividers are not drawn if the menu id disabled? Looks like the divider is drawn for Share though.

Comment 3

[Brian Nicholson (:bnicholson)]

Can't reproduce this on the Android emulator -- have you seen this on non-x86 tablets as well?

Comment 4

[Aaron Train [:aaronmt]]

Yes. On my Xperia Tablet Z: bug 970365. 

Forgot I filed this. Duping my new one

Comment 6

[Aaron Train [:aaronmt]]

Sony Xperia Z Tablet screenshot: https://bugzilla.mozilla.org/attachment.cgi?id=8373393

Comment 7

[Brian Nicholson (:bnicholson)]

Attachment: Override MenuItemsAdapter#areAllItemsEnabled to always be true

Having a ListView item disabled hides the dividers for that item, and this appears to be the "intended behavior" [1]. The workaround, according to several sources ([2], [3], etc.) is to override areAllItemsEnabled in the adapter to always return true. I can verify that this fixes the divider issue, and the individual items are still disabled as expected.

[1] https://groups.google.com/d/msg/android-developers/uoiJo0djRZ8/wb-iOy5bmawJ
[2] http://stackoverflow.com/a/9197037/1524401
[3] http://java.dzone.com/articles/android-listview-%E2%80%93-fixing

Comment 8

[Wesley Johnston (:wesj)]

Comment on attachment 8379549 [details] [diff] [review]
Override MenuItemsAdapter#areAllItemsEnabled to always be true

Review of attachment 8379549 [details] [diff] [review]:
-----------------------------------------------------------------

:(

Comment 9

[Brian Nicholson (:bnicholson)]

Yeah, I don't like this fix either. When areAllItemsEnabled() returns true, individual items can still still be disabled, so what does areAllItemsEnabled() actually *do*?

https://hg.mozilla.org/integration/fx-team/rev/8f547ee05df3

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8f547ee05df3