1050816 - Update about:customizing header style and border

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[:Gijs (he/him)]

Per http://people.mozilla.org/~mmaslaney/firefox/Australis-OSX-Yosemite-Customize.png , we should update the header style. I don't think anything else much has changed specific to customize mode, unless the background is subtly different (it'd be worth checking that) - Michael, can you doublecheck that I've not missed something important in that particular mockup (specific to customize mode) ?

IMO, this style is much nicer than the green-ish shade we currently use, and we should just update it generally, not just for OS X Yosemite. It also seems in line with the general in-content prefs styling. Would that be OK? :-)

Comment 1

[:Gijs (he/him)]

Per discussion with mmaslaney, we're going to just update to use this style throughout other OSes, too.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Given that it's cross-platform, I suppose this should be more than 1 point? Do all platforms need updating? Are there mockups/details for the other platform changes?

Comment 3

[:Gijs (he/him)]

(In reply to :Gavin Sharp [email: [e-mail]] from comment #2)
> Given that it's cross-platform, I suppose this should be more than 1 point?
> Do all platforms need updating? Are there mockups/details for the other
> platform changes?

This is just the in-content about:customizing page. I think the mockup that's there is fine, and all the styles are, as best I know of, in a single shared/ theme file anyway. So I don't think so, I guess?

Comment 4

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch (intermittently here 14-15 August; then away until 19th) from comment #3)
> (In reply to :Gavin Sharp [email: [e-mail]] from comment #2)
> > Given that it's cross-platform, I suppose this should be more than 1 point?
> > Do all platforms need updating? Are there mockups/details for the other
> > platform changes?
> 
> This is just the in-content about:customizing page. I think the mockup
> that's there is fine, and all the styles are, as best I know of, in a single
> shared/ theme file anyway. So I don't think so, I guess?

Specifically:

http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/customizeMode.inc.css#96

Comment 5

[Michael Maslaney [:mmaslaney] ([e-mail])]

(In reply to :Gavin Sharp [email: [e-mail]] from comment #2)
> Given that it's cross-platform, I suppose this should be more than 1 point?
> Do all platforms need updating? Are there mockups/details for the other
> platform changes?

If it helps, I am happy to provide a mockup of each. The changes design-wise are fairly minimal, with the height scaling up to 26px and the color changing from blue to black.

Comment 6

[:Gijs (he/him)]

Attachment: update about:customizing header,

Switched some padding to margin to position the border correctly. I've left font family to be platform-dependent as it is now.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8478263 [details] [diff] [review]
update about:customizing header,

Review of attachment 8478263 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 8

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/9837d1b9bdc6

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9837d1b9bdc6

Comment 10

[alex_mayorga]

Attachment: Missing right dotted border

¡Hola Gijs!

Is the right dotted border missing on my screen capture an overlook?

Comment 11

[:Gijs (he/him)]

(In reply to alex_mayorga from comment #10)
> Created attachment 8480092 [details]
> Missing right dotted border
> 
> ¡Hola Gijs!
> 
> Is the right dotted border missing on my screen capture an overlook?

My patch here didn't change that - it only changed the title inside the customize mode palette ("Additional Tools and Features". If you can reproduce on a clean profile, please file a separate bug with more details.

Comment 12

[alex_mayorga]

"Additional Tools and Features" now shows on about:customizing page with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140827030202 CSet: 0753f7b93ab7

Comment 13

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Ubuntu 13.10 32bit and Mac OSX 10.9.4 using latest Nightly 34.0a1 (buildID: 20140828030205).