1050877 - media.gmp-manager.url should mention GMP

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Andrew McCreight (out until 2026) [:mccr8]]

Right now, it is set to dummy.xml, which made figuring out that bug 1046182 was GMP related much harder.  If the name was changed to something like dummy-gmp-manager-url.xml or something it would be more obvious what it is.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

georg: you want to take this?

Comment 2

[Georg Fritzsche [:gfritzsche]]

Adding to our backlog - not taking it right now as it isn't critical and i have some things to finish up.

Comment 3

[Georg Fritzsche [:gfritzsche]]

There's two places where the dummy.xml URL has to be changed:
http://mxr.mozilla.org/mozilla-central/search?string=%2Fdummy.xml&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 4

[Aseem Raj Baranwal]

Attachment: bug1050877.patch

I just gave this a try. Please review if I'm on the right track.

Comment 5

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8477859 [details] [diff] [review]
bug1050877.patch

Review of attachment 8477859 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, this looks good!
Looking at this now, i would change it to dummy-gmp-manager.xml (the "-url" part seems redundant as this is a URL) and then request review from jmaher for this.

Comment 6

[Aseem Raj Baranwal]

Attachment: bug1050877.patch

Thank you for replying.
I dropped the -url and now it is simply "dummy-gmp-manager.xml"
Please review and confirm.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8478536 [details] [diff] [review]
bug1050877.patch

Review of attachment 8478536 [details] [diff] [review]:
-----------------------------------------------------------------

Aseem, thanks for posting this patch.  In reading over this, I don't see where we defined dummy-gmp-manager.xml.  Do we expect it to really be accessible?  This patch does what the bug asks for, but I would like to learn more about why we are naming this.  Also should we be updating reftest and talos at all?

Comment 8

[Georg Fritzsche [:gfritzsche]]

(In reply to Joel Maher (:jmaher) from comment #7)
> Aseem, thanks for posting this patch.  In reading over this, I don't see
> where we defined dummy-gmp-manager.xml.Do we expect it to really be
> accessible?

No, the previous URL wasn't accessible either. We just want things to fail sanely.

> Also should we be updating reftest and talos at all?

Talos was adressed here previously:
https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1042161&attachment=8470802
Where should reftest be adressed?

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

reftest is here:
http://dxr.mozilla.org/mozilla-central/source/layout/tools/reftest/reftest-preferences.js

I am not sure we need to do anything for reftest.  Glad you have taken care of these things!

Comment 10

[Georg Fritzsche [:gfritzsche]]

Given this was just about naming the existing prefs, i think we're good here.
Trivial renaming, so i don't think we need a try run here.

Comment 11

[Andrew McCreight (out until 2026) [:mccr8]]

Thanks for fixing this!

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a019b75127fd

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c6a1dec30988

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a019b75127fd