Closed
Bug 1050899
Opened 10 years ago
Closed 10 years ago
Crash in GonkGPSGeolocationProvider::SetAGpsDataConn
Categories
(Core :: DOM: Geolocation, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| b2g-v1.4 | --- | fixed |
| b2g-v2.0 | --- | unaffected |
| b2g-v2.1 | --- | fixed |
People
(Reporter: khuey, Assigned: kanru)
References
Details
(Keywords: crash)
Attachments
(1 file)
|
2.66 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
My Nexus 5 reliably crashes with a null dereference of mAGpsRilInterface when doing GPS at http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/GonkGPSGeolocationProvider.cpp#341.
|
||
Comment 1•10 years ago
|
||
I assume khuey is using B2G 2.1 and that 1.4 is also affected because regressing bug 1032063 was uplifted mozilla-b2g30_v1_4.
Blocks: geo-b2g, mls-dolphin
status-b2g-v1.4:
--- → affected
status-b2g-v2.0:
--- → unaffected
status-b2g-v2.1:
--- → affected
|
Reporter | |
Comment 2•10 years ago
|
||
Yeah, I'm using trunk.
|
|
||
Comment 3•10 years ago
|
||
Kan-Ru: this crash is a regression from update_network bug 1032063.
Assignee: nobody → kchen
Flags: needinfo?(kchen)
|
Assignee | |
Comment 4•10 years ago
|
||
Right. We ensure we have mAGpsInterface at that point but we have to check mAGpsRilInterface before use.
Flags: needinfo?(kchen)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Attachment #8473637 -
Flags: review?(dougt)
|
||
Updated•10 years ago
|
Attachment #8473637 -
Flags: review?(dougt) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 6•10 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
|
Assignee | |
Comment 8•10 years ago
|
||
[Blocking Requested - why for this release]:
This fixes a regression of a 1.4+ bug.
blocking-b2g: --- → 1.4?
|
||
Comment 9•10 years ago
|
||
As a regression.
(In reply to Kan-Ru Chen [:kanru] from comment #8)
> [Blocking Requested - why for this release]:
>
> This fixes a regression of a 1.4+ bug.
blocking-b2g: 1.4? → 1.4+
|
|
||
Comment 10•10 years ago
|
||
|
|
||
Comment 11•10 years ago
|
||
Comment on attachment 8473637 [details] [diff] [review]
Check mAGpsRilInterface before use
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 1032063
User impact if declined: This crash fix is necessary for bug 1032063, which is a 1.4+ blocker that we'd like to fix on 2.0. That fix will improve geolocation and FMD on non-QC devices. (QC replaces our Gecko geolocation code with their own.)
Testing completed: Dolphin running 1.4
Risk to taking this patch (and alternatives if risky): Low risk. This patch just adds some null pointer checks.
String or UUID changes made by this patch: None
|
||
Updated•10 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•