1051510 - Show throbbers on existing conversations already while connecting

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[aleth [:aleth]]

I believe the occasional apparent lack of responsiveness when using /back I looked at in bug 1045622 is really due to now expecting to see throbbers if existing channels are being reconnected - but the throbbers only show up after joinChat is called, not during the entire Connecting... phase.

There's a simple fix to make this a little bit better (without addressing any possible wider questions about feedback to the user).

Comment 1

[aleth [:aleth]]

Attachment: connectthrobbing.diff

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8470453 [details] [diff] [review]
connectthrobbing.diff

Review of attachment 8470453 [details] [diff] [review]:
-----------------------------------------------------------------

So to ensure I understand this...it will mark channels as joining during connection instead of once we sent the JOIN command? I'd really like if we could think about moving some of these conditions out of the IRC code, I.e. This bug will exist in XMPP even after this patch.

Comment 3

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #2)
> So to ensure I understand this...it will mark channels as joining during
> connection instead of once we sent the JOIN command? I'd really like if we
> could think about moving some of these conditions out of the IRC code, I.e.
> This bug will exist in XMPP even after this patch.

Yes to all of that.

Comment 4

[Patrick Cloke [:clokep]]

Sounds good! If we don't have a bug filed about moving some of this reconnect logic out of the prpls, can we file one? Thanks for the patch! :-)

Comment 5

[Patrick Cloke [:clokep]]

Thanks!

https://hg.mozilla.org/comm-central/rev/2f4be5bad7db

Can you file that follow up bug?