1051513 - Removed activities still exist after a first-run state

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Kevin Grandon :kgrandon]

STR:
1 - Remove an activity from a manifest, and run make install-gaia.
2 - Run the script here: https://github.com/AntonioMA/gaiatools/blob/master/resetApps.sh

Expected:
Activity that you removed is no longer an option.

Actual:
Activity that you removed remains.

Comment 1

[[:fabrice] Fabrice Desré]

The issue is that we fail to remove "old" activities for preloaded apps because we don't have the old manifest anymore. We can likely fix that by just removing all the activities for a given appId instead.

Comment 2

[Chris Lord [:cwiiis]]

May have a patch for this, but having difficulty debugging... Will attach WIP if I make no progress.

Comment 3

[Chris Lord [:cwiiis]]

Attachment: Fix updating web activity registration

Not an area of code I'm familiar with, so not really sure this is the right thing to do, but debugging lead me to think it is.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 8470984 [details] [diff] [review]
Fix updating web activity registration

Review of attachment 8470984 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, thanks!

Comment 5

[Chris Lord [:cwiiis]]

Attachment: Fix updating web activity registration (v2)

Carrying r+, just removing some redundant code. Will push when I'm awake and the tree's open :)

Comment 6

[Chris Lord [:cwiiis]]

Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/957e7446d3f7

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/957e7446d3f7