1051530 - whether a decode error put our image state into error depends on when the decode starts in relation to the network load event for the image

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Timothy Nikkel (:tnikkel)]

In nsImageLoadingContent whether a decode error put our image state into error depends on when the decode starts in relation to the network load event for the image. In nsImageLoadingContent::OnStopRequest if a decode has been started then we wait until the decode is complete to fire the load/error event. When we fire this event we also update the image state. However if a decode has not started by the time OnStopRequest runs, but a decode does happen later then when it completes nsImageLoadingContent::Notify does nothing, and our image state stays as non-error.

This is the cause of bug 930894, bug 920493, bug 921207, bug 918419, bug 918712, and is the reason the patch in bug 1008942 causes test failures.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Not really sure who would be a good reviewer for this. Kyle, let me know if you have a better idea.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Given that bz is on vacation I am probably the best candidate.

Comment 3

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8470473 [details] [diff] [review]
patch

Maybe bz can get to this.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8470473 [details] [diff] [review]
patch

Yeah, this seems pretty reasonable.

Comment 5

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8470473 [details] [diff] [review]
patch

Thanks!

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0e0d6b70a43d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Can we land this on Aurora33 as well?

Comment 8

[Timothy Nikkel (:tnikkel)]

Are the intermittent's causing that much trouble for the sheriffs? They seem to be pretty rare right now, and since aurora becomes beta in a few days I wouldn't mind the extra bake time.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

If you're worried about baking, we can live without it.