1051538 - Linking contact never ends

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Matěj Cepl]

Attachment: logcat-log.txt

When clicking on "Propojit kontact" (Link contact in Czech) even though I have an address book full of Facebook accounts, does never end (the message is "Have a little bit of patience. Calculation of suggestions is going on.").

See attached logcat log for the moment when the error happened.

Comment 1

[Matěj Cepl]

Using http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central-flame/ (with http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central-flame/b2g-34.0a1.en-US.android-arm.tar.gz and gaia.zip from 2014-08-09)

Comment 2

[Josh Schmitt [Joshs]]

I am seeing this issue on todays 2.1 Flame 319MB build.

I proceed to a contact, select link and the message "Please hold on. We are calculating a proposal." nothing progresses from there.

Environmental Variables:
Device: Flame Master 319MB
Build ID: 20140811040202
Gaia: 19ed3c9e78eaf234cc08484bde6998ae21552ba5
Gecko: a9b43778f0c2
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Issue does NOT repro on 2.0 Flame 319MB build.

After selecting link, either a Facebook login page appears or my contacts are shown.

Enviromental Variables:
Device: Flame 2.0 319MB
BuildID: 20140811000210
Gaia: de28796a8956a48bb98ca67df6a33e0622d642d1
Gecko: 5256345f62bd
Version: 32.0 (2.0)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 3

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Is a regression and a smoke test blocker.

Requesting a window.

Comment 4

[Joshua Mitchell (Inactive)]

Qa-Wanted is not able to reproduce this issue. Using the same build as comment 2 and using these STR

1) Flash phone
2) proceed past FTU (connected to wifi during this phase)
3) Select Contacts
4) Select Settings (gear)
5) Activate Toggle to synch Facebook Friends 
6) Sign into Facebook
7) Choose 'Select All'
8) Select 'Import'

Actual Results - all selected contacts / friends are imported into Contacts

Device: Flame Master (319 mem)
Build ID: 20140811040202
Gaia: 19ed3c9e78eaf234cc08484bde6998ae21552ba5
Gecko: a9b43778f0c2
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Josh S. and Matej - can you review my steps and see if you are doing something different to get this bug to occur? No one mentions repro-rate. I flashed my device 5 times and repeated the STRs and did not repro once.

Comment 5

[Joshua Mitchell (Inactive)]

Got updated steps off-line from Josh

Comment 6

[Joshua Mitchell (Inactive)]

I will not be able to finish this window until tomorrow however - here is my initial window

Mozilla Central Regression Window:

Last Working:
Device: Flame Master
Build ID: 20140808074137
Gaia: c45627132ae7f00026e361a14d5d084a1236af24
Gecko: 96a566fa1599
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken:
Device: Flame Master
Build ID: 20140808083037
Gaia: c97d1b6c3094e854377b6affa5f46b8d4b7316ce
Gecko: 2c56f2d98018
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: c45627132ae7f00026e361a14d5d084a1236af24
Gecko: 2c56f2d98018

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: c97d1b6c3094e854377b6affa5f46b8d4b7316ce
Gecko: 96a566fa1599

Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/c45627132ae7f00026e361a14d5d084a1236af24...c97d1b6c3094e854377b6affa5f46b8d4b7316ce



and in the meantime -  it seems like this might be caused by bug  1045521

Comment 7

[Jason Smith [:jsmith]]

Adrian - Could bug 1045521 caused this regression?

Comment 8

[Adrián de la Rosa]

I think yes, mainly because of this line found in logcat:

E/GeckoConsole(10614): [JavaScript Error: "ReferenceError: ImportStatusData is not defined" {file: "app://communications.gaiamobile.org/contacts/gaia_build_defer_fb_link.js" line: 40}]

I'll start working on it and I will try to fix it ASAP.

Comment 9

[Matěj Cepl]

(In reply to Joshua Mitchell [:Joshua_M] from comment #4)
> Josh S. and Matej - can you review my steps and see if you are doing
> something different to get this bug to occur? No one mentions repro-rate. I
> flashed my device 5 times and repeated the STRs and did not repro once.

Just to emphasize: I have no problems whatsoever with importing friends from Facebook itself. I have both Facebook and non-Facebook contacts in my contacts list. The only problem is with linking these two types together.

Comment 10

[Adrián de la Rosa]

Attachment: Pull request #22778

Comment 11

[Jose Manuel Cantera]

Comment on attachment 8471470 [details]
Pull request #22778

thanks Adrian

Comment 12

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/d51e2a37baaeacd43eaca577ef2968beceb93719

Comment 13

[Josh Schmitt [Joshs]]

Verified fixed, I am now able to link/unlink contacts without any issues.

Environmental Variables:
Device: Flame Master 319MB & 512MB
Build ID: 20140814040202
Gaia: 5e074831f9ddacdf6f622a6dffaecb626f740be8
Gecko: 5299864050ee
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 14

[bhavana bajaj [:bajaj]]

Switching the 2.1?->2.1+, on these fixed bugs as these are regression.

Nothing to land here, its just flag-cleanup of 2.1? list. Please Ni me if there is confusion/disagreement.